Skip to content

Commit 08ce7ca

Browse files
authored
Challenge edits (#94)
1 parent 4f14f6f commit 08ce7ca

File tree

8 files changed

+16
-9
lines changed

8 files changed

+16
-9
lines changed

week_2/workspaces/resources.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def uri(self):
2323
return f"postgresql://{self.user}:{self.password}@{self.host}/{self.database}"
2424

2525
def execute_query(self, query: str):
26-
self._engine.execute(query)
26+
return self._engine.execute(query)
2727

2828

2929
class S3:

week_3/workspaces/challenge/week_3_challenge.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def load_input(self, context):
1313
pass
1414

1515

16-
@io_manager(required_resource_keys={"postgres"})
16+
@io_manager(required_resource_keys={"database"})
1717
def postgres_io_manager(init_context):
1818
return PostgresIOManager()
1919

week_3/workspaces/project/week_3.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ def week_3_pipeline():
6262
"bucket": "dagster",
6363
"access_key": "test",
6464
"secret_key": "test",
65-
"endpoint_url": "http://localstack:4566",
65+
"endpoint_url": "http://localhost:4566",
6666
}
6767
},
6868
"redis": {

week_3/workspaces/resources.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def uri(self):
2424
return f"postgresql://{self.user}:{self.password}@{self.host}/{self.database}"
2525

2626
def execute_query(self, query: str):
27-
self._engine.execute(query)
27+
return self._engine.execute(query)
2828

2929

3030
class S3:

week_4/workspaces/challenge/repo.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
create_dbt_table,
55
dbt_assets,
66
end,
7-
insert_dbt_data,
7+
dbt_table,
88
)
99
from workspaces.dbt_config import DBT_PROJECT_PATH
1010
from workspaces.resources import postgres_resource
@@ -13,7 +13,7 @@
1313
@repository
1414
def repo():
1515
return with_resources(
16-
dbt_assets + [create_dbt_table, insert_dbt_data, end],
16+
dbt_assets + [create_dbt_table, dbt_table, end],
1717
resource_defs={
1818
"dbt": dbt_cli_resource.configured(
1919
{

week_4/workspaces/challenge/week_4_challenge.py

+8-1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
@asset(
1111
required_resource_keys={"database"},
1212
op_tags={"kind": "postgres"},
13+
key_prefix=["postgresql"],
1314
)
1415
def create_dbt_table(context):
1516
sql = "CREATE SCHEMA IF NOT EXISTS analytics;"
@@ -21,8 +22,9 @@ def create_dbt_table(context):
2122
@asset(
2223
required_resource_keys={"database"},
2324
op_tags={"kind": "postgres"},
25+
key_prefix=["postgresql"],
2426
)
25-
def insert_dbt_data(context, create_dbt_table):
27+
def dbt_table(context, create_dbt_table):
2628
sql = f"INSERT INTO {SOURCE_TABLE} (column_1, column_2, column_3) VALUES ('A', 'B', 'C');"
2729

2830
number_of_rows = randint(1, 10)
@@ -31,3 +33,8 @@ def insert_dbt_data(context, create_dbt_table):
3133
context.log.info("Inserted a row")
3234

3335
context.log.info("Batch inserted")
36+
37+
38+
@asset
39+
def end(context):
40+
pass

week_4/workspaces/dbt_config.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
DBT_PROJECT_PATH = "/opt/dagster/dagster_home/project/dbt_test_project"
1+
DBT_PROJECT_PATH = "/opt/dagster/dagster_home/dbt_test_project"

week_4/workspaces/resources.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def uri(self):
2323
return f"postgresql://{self.user}:{self.password}@{self.host}/{self.database}"
2424

2525
def execute_query(self, query: str):
26-
self._engine.execute(query)
26+
return self._engine.execute(query)
2727

2828

2929
class S3:

0 commit comments

Comments
 (0)