Support optional params on root (#367)

Signed-off-by: Matteo Collina <hello@matteocollina.com>

Author: mcollina

index.js

@@ -115,7 +115,7 @@ Router.prototype.on = function on (method, path, opts, handler, store) {
     assert(path.length === optionalParamMatch.index + optionalParamMatch[0].length, 'Optional Parameter needs to be the last parameter of the path')
 
     const pathFull = path.replace(OPTIONAL_PARAM_REGEXP, '$1$2')
-    const pathOptional = path.replace(OPTIONAL_PARAM_REGEXP, '$2')
+    const pathOptional = path.replace(OPTIONAL_PARAM_REGEXP, '$2') || '/'
 
     this.on(method, pathFull, opts, handler, store)
     this.on(method, pathOptional, opts, handler, store)

test/optional-params.test.js

@@ -195,3 +195,23 @@ test('deregister a route with optional param', (t) => {
   t.notOk(findMyWay.find('GET', '/a/:param/b'))
   t.notOk(findMyWay.find('GET', '/a/:param/b/:optional'))
 })
+
+test('optional parameter on root', (t) => {
+  t.plan(2)
+  const findMyWay = FindMyWay({
+    defaultRoute: (req, res) => {
+      t.fail('Should not be defaultRoute')
+    }
+  })
+
+  findMyWay.on('GET', '/:optional?', (req, res, params) => {
+    if (params.optional) {
+      t.equal(params.optional, 'foo')
+    } else {
+      t.equal(params.optional, undefined)
+    }
+  })
+
+  findMyWay.lookup({ method: 'GET', url: '/', headers: {} }, null)
+  findMyWay.lookup({ method: 'GET', url: '/foo', headers: {} }, null)
+})