Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ToV8 and FromV8 derive macros #1075

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Feb 12, 2025

Adds a ToV8 and FromV8 macro, similar to the WebIDL macro

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 92.41379% with 22 lines in your changes missing coverage. Please review.

Project coverage is 81.34%. Comparing base (0c7f83e) to head (824a2cc).
Report is 255 commits behind head on main.

Files with missing lines Patch % Lines
core/convert.rs 66.66% 7 Missing ⚠️
ops/v8/structs.rs 92.70% 7 Missing ⚠️
ops/lib.rs 80.00% 2 Missing ⚠️
ops/v8/from.rs 97.10% 2 Missing ⚠️
ops/v8/to.rs 96.22% 2 Missing ⚠️
core/fast_string.rs 0.00% 1 Missing ⚠️
ops/v8/mod.rs 97.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1075      +/-   ##
==========================================
- Coverage   81.43%   81.34%   -0.10%     
==========================================
  Files          97      105       +8     
  Lines       23877    28353    +4476     
==========================================
+ Hits        19445    23064    +3619     
- Misses       4432     5289     +857     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crowlKats crowlKats requested a review from nathanwhit February 12, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants