refactor(html): move more tailwind usage to defined classes #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-collinsworth
approved these changes
Apr 22, 2024
Comment on lines
+216
to
245
| .usage { | ||
| @apply px-6 py-5 mb-4 border max-md:border-x-0 md:rounded-lg bg-stone-50 border-stone-200; | ||
|
|
||
| nav { | ||
| @apply flex items-center flex-row gap-2 mb-3 font-semibold; | ||
|
|
||
| details { | ||
| > summary { | ||
| @apply flex gap-1 select-none cursor-pointer rounded border border-gray-300 py-2 px-3; | ||
| } | ||
|
|
||
| > div { | ||
| @apply md:relative; | ||
|
|
||
| > div { | ||
| @apply absolute max-md:inset-x-0 mt-1.5 p-2 block z-30 md:w-72 bg-white md:rounded border max-md:border-x-0 border-gray-300; | ||
|
|
||
| label { | ||
| @apply flex items-center justify-between cursor-pointer select-none px-2 py-1 leading-normal rounded-sm hover:bg-gray-50; | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| pre.highlight { | ||
| @apply border border-gray-300 max-md:border-x-0; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Question: is this selector nesting compiled away?
If so, disregard this comment. But otherwise, nesting is fairly well supported, but still new enough it may be risky to use, especially without the & syntax. https://caniuse.com/?search=nesting
There was a problem hiding this comment.
yep, its compiled away. I know tailwind supports nesting, but as also pass the stylesheet through lightningcss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.