feat(config): typography 및 fontWeight설정 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qkrdmstlr3
requested review from
woo-jk,
Collection50 and
eunbeann
as code owners
qkrdmstlr3
requested review from
eunbeann,
Collection50 and
woo-jk
and removed request for
eunbeann,
woo-jk and
Collection50
Comment on lines
+16
to
+17
| const fontWeightToken = fontWeightVariant.reduce((acc, token) => ({ ...acc, [token]: fontWeight[token] }), {}); | ||
|
|
There was a problem hiding this comment.
이 부분과 아래 extend의 fontSize는 tailwind에서 제공하는 유틸리티와 동일한 것으로 보여지는데 맞을까요??
There was a problem hiding this comment.
아 그러네요. fontSize는 기존 extend문에 추가하였고, fontWeight도 비슷한 위치에 넣어주었습니다. extend 대신 theme에 바로 넣는 것을 기대하셨을까요?
woo-jk
approved these changes
Jul 31, 2024
Comment on lines
+37
to
+39
| body1: '24px', | ||
| body2: '22px', | ||
| label1: '20px', |
There was a problem hiding this comment.
피그마를 보니 body1, body2, label1 토큰 같은 경우 Reading이라는 속성이 있는 것 같은데, 이 부분은 대응을 안해도 괜찮을까요?
There was a problem hiding this comment.
사실 어떻게 이름을 지어야할지 몰라서.. 필요할 때 추가하려했습니다 ㅠ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 무슨 이유로 코드를 변경했나요?
typography와 fontWeight토큰을 추가합니다.
3. 관련 스크린샷을 첨부해주세요.
5. 추가 사항 / 코드 리뷰 받고 싶은 부분
typography는 text prefix와 함께, fontWeight는 font prefix와 함께 사용합니다