fix: fix tests without introducing a regression bug

Signed-off-by: aaronschweig <aaron.schweig@gmail.com>
derailed · Feb 18, 2025 · f811f44 · f811f44
1 parent aacbb7c
commit f811f44
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/internal/model1/helpers.go b/internal/model1/helpers.go
@@ -50,7 +50,7 @@ func IsValid(ns string, h Header, r Row) bool {
 		return true
 	}
 
-	return strings.ToLower(strings.TrimSpace(r.Fields[idx])) == "true"
+	return strings.TrimSpace(r.Fields[idx]) == "" || strings.ToLower(strings.TrimSpace(r.Fields[idx])) == "true"
 }
 
 func sortLabels(m map[string]string) (keys, vals []string) {

diff --git a/internal/render/pod_test.go b/internal/render/pod_test.go
@@ -45,7 +45,7 @@ func TestPodColorer(t *testing.T) {
 			re: model1.RowEvent{
 				Kind: model1.EventAdd,
 				Row: model1.Row{
-					Fields: model1.Fields{"blee", "fred", "1/1", "0", render.Running, "true"},
+					Fields: model1.Fields{"blee", "fred", "1/1", "0", render.Running, ""},
 				},
 			},
 			e: model1.StdColor,
@@ -115,7 +115,7 @@ func TestPodColorer(t *testing.T) {
 			re: model1.RowEvent{
 				Kind: model1.EventAdd,
 				Row: model1.Row{
-					Fields: model1.Fields{"blee", "fred", "1/1", "0", "blee", "true"},
+					Fields: model1.Fields{"blee", "fred", "1/1", "0", "blee", ""},
 				},
 			},
 			e: model1.AddColor,