feat: Pause/Resume Deployments #2954
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorbenbelow
force-pushed
the
feat/add-pause-and-resume-cmds
branch
from
3c0a834 to
c5ee027
Compare
derailed
reviewed
Nov 16, 2024
internal/dao/dp.go
Outdated
| @@ -123,6 +123,30 @@ func (d *Deployment) Restart(ctx context.Context, path string) error { | |||
| return err | |||
| } | |||
|
|
|||
| // Pause a Deployment | |||
| func (d *Deployment) Pause(ctx context.Context, path string) error { | |||
There was a problem hiding this comment.
Given pause/resume are used in tandem, I think we could dry this up and use TogglePause(...) instead.
This will be inline with cronjobs and other resources where we offer toggling behavior
What do you think?
|
@thorbenbelow Looks like this has conflicts and needs TLC. Could you take another look? |
derailed
added
enhancement
thorbenbelow
force-pushed
the
feat/add-pause-and-resume-cmds
branch
3 times, most recently
from
ba4e273 to
3d1920b
Compare
|
Hey @derailed, I followed your suggestion and aligned the behavior with existing toggle implementations. As a result, I removed the multi-selection switch since I felt it would have made things more confusing. Let me know if you have any further suggestions! |
Signed-off-by: Thorben Below <56894536+thorbenbelow@users.noreply.github.com>
thorbenbelow
force-pushed
the
feat/add-pause-and-resume-cmds
branch
from
3d1920b to
99ab3cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new feature requested in #2792.
Deployments can be paused and resumed.
Description
There is now a new column in the deployments view that shows if a deployment is paused.
Deployments can be paused or resumed using the
zshortcut. The action depends on the current status of the deployment.When there are multiple deployments selected the user has to choose between pausing or resuming them. The default isPause.