fix(coloring): invalid color application for rows with VALID column #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aaronschweig <aaron.schweig@gmail.com>
Signed-off-by: aaronschweig <aaron.schweig@gmail.com>
Signed-off-by: aaronschweig <aaron.schweig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During usage of k9s we saw one specific CRD of ours always show up in an error color despite it being fully ready an healthy
After some investigation I found, that the error color is applied by the default
ColoringFuncin case the resource is deemed not valid. After finding the code for this, I figured that the logic in case a "VALID" column seems to be incorrect, as it deems the resource invalid if its something else than an empty string.I tried fixing it in this PR and also added some tests to this previously untested helper function
With the adjusted logic, the rendering seems to be correct!