@@ -410,19 +410,12 @@ def _setup_whittaker(self, y, lam=1, diff_order=2, weights=None, copy_weights=Fa
410
410
if self ._sort_order is not None and weights is not None :
411
411
weight_array = weight_array [self ._sort_order ]
412
412
413
- if False :#(
414
- #TODO can probably keep the basis for reuse if using SVD, like _setup_spline does, and
415
- # retain the unmodified penalties for the rows and columns if possible to skip that
416
- # calculation as well
417
-
418
- #self.whittaker_system is not None
419
- #and self.whittaker_system.same_basis(diff_order, num_eigens)
420
- #):
421
- self .whittaker_system .update_penalty (lam )
422
- else :
423
- whittaker_system = WhittakerSystem2D (
424
- self ._shape , lam , diff_order , num_eigens
425
- )
413
+ # TODO can probably keep the basis for reuse if using SVD, like _setup_spline does, and
414
+ # retain the unmodified penalties for the rows and columns if possible to skip that
415
+ # calculation as well
416
+ whittaker_system = WhittakerSystem2D (
417
+ self ._shape , lam , diff_order , num_eigens
418
+ )
426
419
if not whittaker_system ._using_svd :
427
420
y = y .ravel ()
428
421
weight_array = weight_array .ravel ()
@@ -607,7 +600,7 @@ def _setup_spline(self, y, weights=None, spline_degree=3, num_knots=10,
607
600
):
608
601
self ._spline_basis = SplineBasis2D (self .x , self .z , num_knots , spline_degree )
609
602
610
- #TODO should probably also retain the unmodified penalties for the rows and
603
+ # TODO should probably also retain the unmodified penalties for the rows and
611
604
# columns if possible to skip that calculation as well
612
605
pspline = PSpline2D (self ._spline_basis , lam , diff_order )
613
606
0 commit comments