Skip to content

Commit d45f74d

Browse files
authored
Tww/#315 recipe scan concentration consideration (#319)
* remove highest result column * Recipe Scan Concentration Consideration * remove useInsightCB
1 parent 3878018 commit d45f74d

File tree

9 files changed

+161
-108
lines changed

9 files changed

+161
-108
lines changed

DB/optionsDB.lua

+9-2
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,8 @@ function CraftSim.DB.OPTIONS:Migrate()
119119
.recipeScanImportAllProfessions
120120
CraftSimDB.optionsDB.data[CraftSim.CONST.GENERAL_OPTIONS.RECIPESCAN_OPTIMIZE_SUBRECIPES] = CraftSimOptions
121121
.recipeScanOptimizeSubRecipes
122-
CraftSimDB.optionsDB.data[CraftSim.CONST.GENERAL_OPTIONS.RECIPESCAN_SORT_BY_PROFIT_MARGIN] = CraftSimOptions
123-
.recipeScanSortByProfitMargin
122+
CraftSimDB.optionsDB.data["RECIPESCAN_SORT_BY_PROFIT_MARGIN"] = CraftSimOptions
123+
["recipeScanSortByProfitMargin"]
124124
CraftSimDB.optionsDB.data[CraftSim.CONST.GENERAL_OPTIONS.RECIPESCAN_USE_INSIGHT] = CraftSimOptions
125125
.recipeScanUseInsight
126126
CraftSimDB.optionsDB.data[CraftSim.CONST.GENERAL_OPTIONS.RECIPESCAN_INCLUDED_PROFESSIONS] = CraftSimOptions
@@ -215,6 +215,13 @@ function CraftSim.DB.OPTIONS:Migrate()
215215

216216
CraftSimDB.optionsDB.version = 3
217217
end
218+
219+
if CraftSimDB.optionsDB.version == 3 then
220+
CraftSimDB.optionsDB.data["RECIPESCAN_SORT_MODE"] = "PROFIT"
221+
CraftSimDB.optionsDB.data["RECIPESCAN_SORT_BY_PROFIT_MARGIN"] = nil
222+
223+
CraftSimDB.optionsDB.version = 4
224+
end
218225
end
219226

220227
function CraftSim.DB.OPTIONS:CleanUp()

Locals/enUS.lua

+8-2
Original file line numberDiff line numberDiff line change
@@ -267,6 +267,7 @@ function CraftSim.LOCAL_EN:GetData()
267267
-- Recipe Scan Frame
268268
[CraftSim.CONST.TEXT.RECIPE_SCAN_TITLE] = "CraftSim Recipe Scan",
269269
[CraftSim.CONST.TEXT.RECIPE_SCAN_MODE] = "Scan Mode",
270+
[CraftSim.CONST.TEXT.RECIPE_SCAN_SORT_MODE] = "Sort Mode",
270271
[CraftSim.CONST.TEXT.RECIPE_SCAN_SCAN_RECIPIES] = "Scan Recipes",
271272
[CraftSim.CONST.TEXT.RECIPE_SCAN_SCAN_CANCEL] = "Cancel",
272273
[CraftSim.CONST.TEXT.RECIPE_SCAN_SCANNING] = "Scanning",
@@ -286,9 +287,10 @@ function CraftSim.LOCAL_EN:GetData()
286287
[CraftSim.CONST.TEXT.RECIPE_SCAN_CRAFTER_HEADER] = "Crafter",
287288
[CraftSim.CONST.TEXT.RECIPE_SCAN_RECIPE_HEADER] = "Recipe",
288289
[CraftSim.CONST.TEXT.RECIPE_SCAN_LEARNED_HEADER] = "Learned",
289-
[CraftSim.CONST.TEXT.RECIPE_SCAN_GUARANTEED_HEADER] = "Guaranteed",
290-
[CraftSim.CONST.TEXT.RECIPE_SCAN_HIGHEST_RESULT_HEADER] = "Highest Result",
290+
[CraftSim.CONST.TEXT.RECIPE_SCAN_RESULT_HEADER] = "Result",
291291
[CraftSim.CONST.TEXT.RECIPE_SCAN_AVERAGE_PROFIT_HEADER] = "Average Profit",
292+
[CraftSim.CONST.TEXT.RECIPE_SCAN_CONCENTRATION_VALUE_HEADER] = "C. Value",
293+
[CraftSim.CONST.TEXT.RECIPE_SCAN_CONCENTRATION_COST_HEADER] = "C. Cost",
292294
[CraftSim.CONST.TEXT.RECIPE_SCAN_TOP_GEAR_HEADER] = "Top Gear",
293295
[CraftSim.CONST.TEXT.RECIPE_SCAN_INV_AH_HEADER] = "Inv/AH",
294296
[CraftSim.CONST.TEXT.RECIPE_SCAN_SORT_BY_MARGIN] = "Sort by Profit %",
@@ -305,6 +307,10 @@ function CraftSim.LOCAL_EN:GetData()
305307
[CraftSim.CONST.TEXT.RECIPE_SCAN_MODE_Q2] = "Materials Quality 2",
306308
[CraftSim.CONST.TEXT.RECIPE_SCAN_MODE_Q3] = "Materials Quality 3",
307309
[CraftSim.CONST.TEXT.RECIPE_SCAN_MODE_OPTIMIZE] = "Optimize Reagents",
310+
[CraftSim.CONST.TEXT.RECIPE_SCAN_SORT_MODE_PROFIT] = "Profit",
311+
[CraftSim.CONST.TEXT.RECIPE_SCAN_SORT_MODE_RELATIVE_PROFIT] = "Relative Profit",
312+
[CraftSim.CONST.TEXT.RECIPE_SCAN_SORT_MODE_CONCENTRATION_VALUE] = "Concentration Value",
313+
[CraftSim.CONST.TEXT.RECIPE_SCAN_SORT_MODE_CONCENTRATION_COST] = "Concentration Cost",
308314
[CraftSim.CONST.TEXT.RECIPE_SCAN_EXPANSION_FILTER_BUTTON] = "Expansions",
309315
[CraftSim.CONST.TEXT.RECIPE_SCAN_ALTPROFESSIONS_FILTER_BUTTON] = "Alt Professions",
310316
[CraftSim.CONST.TEXT.RECIPE_SCAN_SCAN_ALL_BUTTON_READY] = "Scan Professions",

Locals/frFR.lua

-2
Original file line numberDiff line numberDiff line change
@@ -245,8 +245,6 @@ function CraftSim.LOCAL_FR:GetData()
245245
[CraftSim.CONST.TEXT.RECIPE_SCAN_CRAFTER_HEADER] = "Fabricant",
246246
[CraftSim.CONST.TEXT.RECIPE_SCAN_RECIPE_HEADER] = "Recette",
247247
[CraftSim.CONST.TEXT.RECIPE_SCAN_LEARNED_HEADER] = "Apprise",
248-
[CraftSim.CONST.TEXT.RECIPE_SCAN_GUARANTEED_HEADER] = "Garantie",
249-
[CraftSim.CONST.TEXT.RECIPE_SCAN_HIGHEST_RESULT_HEADER] = "Résultat max",
250248
[CraftSim.CONST.TEXT.RECIPE_SCAN_AVERAGE_PROFIT_HEADER] = "Profit moyen",
251249
[CraftSim.CONST.TEXT.RECIPE_SCAN_TOP_GEAR_HEADER] = "Meilleur équipement",
252250
[CraftSim.CONST.TEXT.RECIPE_SCAN_INV_AH_HEADER] = "Sac/HV",

Locals/itIT.lua

-2
Original file line numberDiff line numberDiff line change
@@ -272,8 +272,6 @@ function CraftSim.LOCAL_IT:GetData()
272272
[CraftSim.CONST.TEXT.RECIPE_SCAN_CRAFTER_HEADER] = "Artigiano",
273273
[CraftSim.CONST.TEXT.RECIPE_SCAN_RECIPE_HEADER] = "Ricetta",
274274
[CraftSim.CONST.TEXT.RECIPE_SCAN_LEARNED_HEADER] = "Appresa",
275-
[CraftSim.CONST.TEXT.RECIPE_SCAN_GUARANTEED_HEADER] = "Garantito",
276-
[CraftSim.CONST.TEXT.RECIPE_SCAN_HIGHEST_RESULT_HEADER] = "Risultato migliore",
277275
[CraftSim.CONST.TEXT.RECIPE_SCAN_AVERAGE_PROFIT_HEADER] = "Profitto medio",
278276
[CraftSim.CONST.TEXT.RECIPE_SCAN_TOP_GEAR_HEADER] = "Strumenti",
279277
[CraftSim.CONST.TEXT.RECIPE_SCAN_INV_AH_HEADER] = "Inv/AH",

Locals/ruRU.lua

-2
Original file line numberDiff line numberDiff line change
@@ -245,8 +245,6 @@ function CraftSim.LOCAL_RU:GetData()
245245
[CraftSim.CONST.TEXT.RECIPE_SCAN_CRAFTER_HEADER] = "Ремесленник",
246246
[CraftSim.CONST.TEXT.RECIPE_SCAN_RECIPE_HEADER] = "Рецепт",
247247
[CraftSim.CONST.TEXT.RECIPE_SCAN_LEARNED_HEADER] = "Изучено",
248-
[CraftSim.CONST.TEXT.RECIPE_SCAN_GUARANTEED_HEADER] = "Гарантировано",
249-
[CraftSim.CONST.TEXT.RECIPE_SCAN_HIGHEST_RESULT_HEADER] = "Наивысший результат",
250248
[CraftSim.CONST.TEXT.RECIPE_SCAN_AVERAGE_PROFIT_HEADER] = "Средняя прибыль",
251249
[CraftSim.CONST.TEXT.RECIPE_SCAN_TOP_GEAR_HEADER] = "Лучшая экипировка",
252250
[CraftSim.CONST.TEXT.RECIPE_SCAN_INV_AH_HEADER] = "Инв/Аук",

Locals/zhTW.lua

-2
Original file line numberDiff line numberDiff line change
@@ -232,8 +232,6 @@ function CraftSim.LOCAL_TW:GetData()
232232
[CraftSim.CONST.TEXT.RECIPE_SCAN_OPTIMIZE_TOOLS_WARNING] = "如果你的背包中有很多工具\n掃描期間可能會降低遊戲效能",
233233
[CraftSim.CONST.TEXT.RECIPE_SCAN_RECIPE_HEADER] = "配方",
234234
[CraftSim.CONST.TEXT.RECIPE_SCAN_LEARNED_HEADER] = "已學會",
235-
[CraftSim.CONST.TEXT.RECIPE_SCAN_GUARANTEED_HEADER] = "保證",
236-
[CraftSim.CONST.TEXT.RECIPE_SCAN_HIGHEST_RESULT_HEADER] = "最高結果",
237235
[CraftSim.CONST.TEXT.RECIPE_SCAN_AVERAGE_PROFIT_HEADER] = "平均利潤",
238236
[CraftSim.CONST.TEXT.RECIPE_SCAN_TOP_GEAR_HEADER] = "最佳裝備",
239237
[CraftSim.CONST.TEXT.RECIPE_SCAN_INV_AH_HEADER] = "Inv/AH",

0 commit comments

Comments
 (0)