Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reagent Optimization] Enhance Finishing Reagent Optimization Accuracy by changing optimization order and optimize reagents per finishing reagent (optionally) #768

Open
KyrosKrane opened this issue Dec 3, 2024 · 1 comment
Assignees

Comments

@KyrosKrane
Copy link

Describe the bug
In the reagent optimization and WO reagent optimization windows, the Advanced Optimization option does not seem to take into account the possibility of using +skill finishing reagents with lower-quality mats. Especially for things like smithing recipes, where the price difference in R2/R3 alloys is huge, it's often cheaper to use a +skill reagent and a couple of R2 alloys instead of all R3, for example.

To Reproduce
See the screenshots below. Without the finisher, Advanced Optimization suggests using 5xR5 alloy with a R2 resourcefulness finisher. AdvOp shows a theta of -4061g. But, when I manually add a +20 skill reagent and use 1xR4 4xR5 alloy, it shows a theta of -3909g. If I run AdvOp again, it ignores the +skill slot and shows a max reachable quality of R4, instead of R5. The material costs are also included in the screenshots.

No finisher

With finisher

Mat costs 1

Mat costs 2

Expected behavior
Reagent Optimization recommends the most profitable (or least loss-making) option to complete a work order, including using +skill finishing reagents and lower-quality cheaper mats

Addon Version:
19.7.1

@derfloh205
Copy link
Owner

This is possibly due to the current "order" of optimizations meaning it first optimizes reagents to achieve a target quality and after that it tries to apply +skill finishers (the main idea was to save on concentration by using them)

though to reduce crafting costs and make it cheaper to achieve the target quality craftsim would need to "test" each +skill reagent and for each try to optimize

this is possible but may have a bigger performance impact.. ill test if I could add that as option regarding optimizations

@derfloh205 derfloh205 moved this from Backlog to Ready in CraftSim Jan 15, 2025
@derfloh205 derfloh205 changed the title [Reagent Optimization] RO does not account for +skill finishing reagents [Reagent Optimization] Enhance Finishing Reagent Optimization Accuracy by changing optimization order and optimize reagents per finishing reagent (optionally) Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

No branches or pull requests

2 participants