Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Recipe Scan] Lua crash when scanning specific professions #817

Closed
marklabrecque-ab opened this issue Feb 26, 2025 · 3 comments
Closed

[Recipe Scan] Lua crash when scanning specific professions #817

marklabrecque-ab opened this issue Feb 26, 2025 · 3 comments
Assignees

Comments

@marklabrecque-ab
Copy link

marklabrecque-ab commented Feb 26, 2025

Describe the bug
This occurs on some profession/characters but not others for me. In particular, it looks like it fails while scanning Weavercloth Reagent Bags on Tailoring and on the new Contract: The Cartels of Undermine on Inscription. That's all I have noticed so far, but will update if I notice more. Thanks!

To Reproduce
Steps to reproduce the behavior:

  1. Run a scan recipe on a certain character/profession.
  2. It fails before completion. Error below.

Expected behavior
The recipe scan should complete and not error/crash before finishing.

Screenshots
If applicable, add screenshots to help explain your problem.

Addon Version: [e.g. 19.7.1]

Additional context
Lua Error:
Message: .../Modules/ReagentOptimization/ReagentOptimization.lua:439: attempt to perform arithmetic on field '?' (a nil value)
Time: Wed Feb 26 11:14:15 2025
Count: 1
Stack:
[C]: ?
[Interface/AddOns/CraftSim/Modules/ReagentOptimization/ReagentOptimization.lua]:439: in function 'calculateArrayBP'
[Interface/AddOns/CraftSim/Modules/ReagentOptimization/ReagentOptimization.lua]:469: in function 'OptimizeReagentAllocation'
[Interface/AddOns/CraftSim/Classes/RecipeData.lua]:780: in function 'OptimizeReagents'
[Interface/AddOns/CraftSim/Classes/RecipeData.lua]:1232: in function 'OptimizeProfit'
[Interface/AddOns/CraftSim/Classes/RecipeData.lua]:1864: in function 'OptimizeSubRecipes'
[Interface/AddOns/CraftSim/Classes/RecipeData.lua]:1298: in function 'continue'
[Interface/AddOns/CraftSim/Libs/GUTIL/GUTIL.lua]:1177: in function <Interface/AddOns/CraftSim/Libs/GUTIL/GUTIL.lua:1176>

Locals:

@derfloh205
Copy link
Owner

Make sure to disable SubRecipe Optimization

@derfloh205 derfloh205 moved this from Backlog to Ready in CraftSim Feb 27, 2025
@marklabrecque-ab
Copy link
Author

Yeah it is already. I had similar issues a while ago with that option so I've kept it off.

@derfloh205 derfloh205 moved this from Ready to In progress in CraftSim Feb 27, 2025
@marklabrecque-ab
Copy link
Author

This is fixed in the new release this morning. Thank you so much, impressively quick turnaround on this issue. Keep up the great work!!

@github-project-automation github-project-automation bot moved this from In progress to Done in CraftSim Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants