Disable craftNext button while crafting #740
Open
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derfloh205
requested changes
Dec 3, 2024
| @@ -1603,7 +1603,8 @@ function CraftSim.CRAFTQ.UI:UpdateQueueDisplay() | |||
| local firstRow = queueTab.content.craftList.activeRows[1] | |||
| local craftButton = firstRow.columns[11].craftButton --[[@as GGUI.Button]] | |||
| local button = craftButton.frame --[[@as Button]] | |||
| queueTab.content.craftNextButton:SetEnabled(button:IsEnabled()) | |||
| local isCrafting = C_TradeSkillUI.IsRecipeRepeating() | |||
There was a problem hiding this comment.
Just tested this api call: C_TradeSkillUI.IsRecipeRepeating()
It seems to be only true if the recipe is crafted with a count of more than 2
If its just crafted once it returns false
Maybe there is another api call to be used here?
There was a problem hiding this comment.
I couldn't find another API call for this. Indeed, when I click "Next: Craft," the button only disables after the second craft.
Maybe registering an event on button click?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the "Next: Craft" button behavior to disable while crafting is in progress.
This improvement makes it easier to monitor crafting progress, especially when managing multiple characters simultaneously on the same screen. It's a simple way to quickly identify whether the crafting process is active or has completed.