Skip to content

Commit 5b822aa

Browse files
authored
fix various type errors (#6)
- suspend() isn't defined on BaseAudioContext - AudioScheduledSourceNode.start() takes an optional offset/duration - AudioNode.channelDidUpdate() takes a numberOfChannels param
1 parent ae48377 commit 5b822aa

9 files changed

+23
-22
lines changed

src/__tests__/api/AudioContext.js renamed to src/__tests__/api/BaseAudioContext.js

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -73,15 +73,6 @@ describe('api/AudioContext', () => {
7373
});
7474

7575
describe('methods', () => {
76-
it('.suspend()', () => {
77-
const target = new AudioContext();
78-
79-
target._impl.suspend = jest.fn();
80-
81-
target.suspend();
82-
expect(target._impl.suspend).toHaveBeenCalledTimes(1);
83-
});
84-
8576
it('.resume()', () => {
8677
const target = new AudioContext();
8778

src/api/AudioScheduledSourceNode.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,14 @@ class AudioScheduledSourceNode extends AudioNode {
1212
this._impl.$onended = callback;
1313
}
1414

15-
start(when) {
16-
this._impl.start(when);
15+
/**
16+
*
17+
* @param {number} when
18+
* @param {number} [offset]
19+
* @param {number} [duration]
20+
*/
21+
start(when, offset, duration) {
22+
this._impl.start(when, offset, duration);
1723
}
1824

1925
stop(when) {

src/api/BaseAudioContext.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,6 @@ class BaseAudioContext extends EventTarget {
6060
return this._impl.getState();
6161
}
6262

63-
suspend() {
64-
return this._impl.suspend();
65-
}
66-
6763
resume() {
6864
return this._impl.resume();
6965
}

src/context/RawDataAudioContext.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,10 @@ export class RawDataAudioContext extends BaseAudioContext {
3535
this.numberOfChannels = numberOfChannels;
3636
}
3737

38+
suspend() {
39+
return this._impl.suspend();
40+
}
41+
3842
createAudioBuffer(
3943
length: number,
4044
sampleRate: number,

src/context/StreamAudioContext.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ class StreamAudioContext extends BaseAudioContext {
110110
if (this.state === RUNNING) {
111111
this._suspend();
112112
}
113-
return super.suspend();
113+
return this._impl.suspend();
114114
}
115115

116116
/**

src/context/WebAudioContext.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ class WebAudioContext extends BaseAudioContext {
7878
if (this._processor) {
7979
this._processor.disconnect();
8080
}
81-
return super.suspend();
81+
return this._impl.suspend();
8282
}
8383

8484
/**

src/impl/AudioBufferSourceNode.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,8 @@ class AudioBufferSourceNode extends AudioScheduledSourceNode {
153153

154154
/**
155155
* @param {number} when
156-
* @param {number} offset
157-
* @param {number} duration
156+
* @param {number} [offset]
157+
* @param {number} [duration]
158158
*/
159159
start(when, offset, duration) {
160160
/* istanbul ignore next */

src/impl/AudioNode.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -308,9 +308,11 @@ class AudioNode extends EventTarget {
308308
}
309309

310310
/**
311-
*
311+
* @param {number} numberOfChannels
312312
*/
313-
channelDidUpdate() {}
313+
channelDidUpdate(numberOfChannels) {
314+
// do nothing
315+
}
314316

315317
/**
316318
*

src/impl/AudioScheduledSourceNode.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,10 @@ class AudioScheduledSourceNode extends AudioSourceNode {
5959

6060
/**
6161
* @param {number} when
62+
* @param {number} [offset]
63+
* @param {number} [duration]
6264
*/
63-
start(when) {
65+
start(when, offset, duration) {
6466
/* istanbul ignore next */
6567
if (this._startTime !== Infinity) {
6668
return;

0 commit comments

Comments
 (0)