Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker Compose Template(s) #232

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Update Docker Compose Template(s) #232

merged 1 commit into from
Jan 25, 2024

Conversation

bamurtaugh
Copy link
Member

Fixes #221

Let me know if this fix should apply to the other Docker Compose Templates in this repo, and I can update the PR accordingly.

Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I thought network_mode: service:db makes all the db ports available in the app service. 🤔

@bamurtaugh
Copy link
Member Author

bamurtaugh commented Jan 25, 2024

That's a great question. Did a quick sanity check with Copilot, and it also thinks this update is necessary:

image

With this in mind, I'll go ahead and merge this change, but please lmk if you think we should hold off!

@bamurtaugh bamurtaugh merged commit 960b5bf into main Jan 25, 2024
3 checks passed
@bamurtaugh bamurtaugh deleted the bamurtaugh-patch-1 branch January 25, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Using localhost in Docker Compose" doc can have some improvement
2 participants