Raise FileNotFoundError instead of panic when opening missing files #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
approved these changes
May 1, 2025
| @@ -32,7 +32,9 @@ impl PyTIFF { | |||
| let reader = store.into_async_file_reader(path); | |||
|
|
|||
| let cog_reader = future_into_py(py, async move { | |||
| let metadata_fetch = PrefetchBuffer::new(reader.clone(), prefetch).await.unwrap(); | |||
There was a problem hiding this comment.
Ideally we should remove all of these unwraps, but we can leave that for the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I am changing
TIFF.openHow I did it
.unwrap()with.map_err(|err| PyFileNotFoundError::new_err(err.to_string()))?FileNotFoundErroris raised for missing filesHow you can test it
cd python && uv run pytest --verboselocally (preferrably on top of Enable pytest-asyncio tests in CI #92)Related Issues
Fixes #90