Read SignedShort as i16, add TiffFormatError::ShortExpected #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For values expected to be u16.
Cherry-picked from image-rs/image-tiff@1e3bcf2
kylebarron
reviewed
May 6, 2025
src/metadata/reader.rs
Outdated
Comment on lines
662
to
663
| ([1,1, 8, 0, 1,0,0,0, 42, 0, 0, 0], Endianness::LittleEndian, Value::SignedShort (42 )), // signedshort | ||
| ([1,1, 0, 8, 0,0,0,1, 0,42, 0, 0], Endianness::BigEndian, Value::SignedShort (42 )), // signedshort |
There was a problem hiding this comment.
All done at commit 098e756
kylebarron
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I am changing
How I did it
TiffFormatError::ShortExpectedenum variantinto_u32_vecandinto_u64_vecmethods.Type::SSHORTas i16 valuesHow you can test it
cargo testlocally.Related Issues