Fix PR integration testing #531
Conversation
|
/hold Waiting to discuss with team in the new year about alternatives before proceeding with this change. |
.ci/openshift_integration.sh
Outdated
| @@ -69,4 +69,4 @@ $(realpath odo) registry delete DefaultDevfileRegistry -f | |||
| $(realpath odo) registry add TestDevfileRegistry http://$REGISTRY_HOSTNAME | |||
|
|
|||
| # Run the devfile validation tests | |||
| ENV=openshift REGISTRY=remote tests/check_odov2.sh $(realpath odo) $YQ_PATH | |||
| ENV=openshift REGISTRY=remote ENABLE_TLS="false" tests/check_odov2.sh $(realpath odo) $YQ_PATH | |||
There was a problem hiding this comment.
I took a second look here. @michael-valdron out of curiosity, could we combine the two issues in the same PR (devfile/api#1664 is the other one). Meaning we could also migrate the check to odo3 here right? This way I guess the ci check will be unblocked
There was a problem hiding this comment.
@thepetk Yeah I can add the change to odov3 testing as well to unblock the testing entirely and resolve both. I'll work on and add it today.
michael-valdron
force-pushed
the
fix/enable-tls-odov2
branch
from
55dcd5f to
960c9b9
Compare
michael-valdron
changed the title
check_odov2.sh and openshift_integration.sh
|
/unhold |
|
/test v4.15-registry-test |
@thepetk Needs ginkgo to be installed, going to setup the binary similar to odo and yq. |
Yeah I've figured from the output. I just wasn't sure if the check had run after you pushed your updates and I wanted to see what will be the result. |
|
/hold Holding till ci/prow/v4.15-registry-test passes. |
michael-valdron
force-pushed
the
fix/enable-tls-odov2
branch
from
4f1a660 to
590e9ea
Compare
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…testing script Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…_DIR instead of relative path Signed-off-by: Michael Valdron <mvaldron@redhat.com>
michael-valdron
force-pushed
the
fix/enable-tls-odov2
branch
from
590e9ea to
b7aec49
Compare
|
/hold Need to merge openshift/release#60441 before this PR can be merged. |
|
@michael-valdron: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/unhold |
There was a problem hiding this comment.
lgtm, I believe the integration test failures are being resolved in a future PR, is that correct @michael-valdron ?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Jdubrick Integration test failures are resolved in this PR, the failing check is for the EC testing which will be temporarily fixed in #546 and permanently resolved by a PR for devfile/api#1667. |
ah yep you're right I misread it, lgtm then |
* Trigger deploy based on devfile/devfile-web@f540461 Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com> * migrate jhipster online to redhat developer demos Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com> * Trigger deploy based on devfile/devfile-web@f540461 Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com> * Fix PR integration testing (#531) * tls enablement for check_odov2.sh and openshift_integration.sh Signed-off-by: Michael Valdron <mvaldron@redhat.com> * replace odov2 with odov3 under integration testing Signed-off-by: Michael Valdron <mvaldron@redhat.com> * fix missing ginkgo and test script argument steps Signed-off-by: Michael Valdron <mvaldron@redhat.com> * correct ENABLE_TLS to ENABLE_TLS_VERIFY for odov2 test script Signed-off-by: Michael Valdron <mvaldron@redhat.com> * remove ENABLE_TLS_VERIFY for odov3 test script run under integration testing script Signed-off-by: Michael Valdron <mvaldron@redhat.com> * revert showing full odo path in test log Signed-off-by: Michael Valdron <mvaldron@redhat.com> * openshift_integration: fix remaining file path references to use BASE_DIR instead of relative path Signed-off-by: Michael Valdron <mvaldron@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com> Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com> * patch konflux pipeline task images (#546) Signed-off-by: Michael Valdron <mvaldron@redhat.com> Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com> * Trigger deploy based on devfile/devfile-web@f540461 Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com> --------- Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com> Signed-off-by: Michael Valdron <mvaldron@redhat.com> Co-authored-by: team-devfile-bot <team-devfile-bot@redhat.com> Co-authored-by: Michael Valdron <mvaldron@redhat.com>
Description of Changes
Summarize the changes you made as part of this pull request.
To fix the current unexpected integration testing failures this PR changes include the following:
curlwhen testing stacks using HTTPS rather than HTTP.Related Issue(s)
Link the GitHub/GitLab/JIRA issues that are related to this PR.
fixes devfile/api#1663
fixes devfile/api#1664
Acceptance Criteria
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
bash .ci/openshift_integration.shNotes To Reviewer
Any notes you would like to include for the reviewer.