Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update konflux references #572

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Conversation

red-hat-konflux[bot]
Copy link
Contributor

This PR contains the following updates:

Package Change Notes
quay.io/konflux-ci/tekton-catalog/task-buildah 78aeb24 -> 9362d1e
quay.io/konflux-ci/tekton-catalog/task-coverity-availability-check 0.1 -> 0.2 ⚠️migration⚠️
quay.io/konflux-ci/tekton-catalog/task-sast-coverity-check 0.1 -> 0.2 ⚠️migration⚠️
quay.io/konflux-ci/tekton-catalog/task-sast-snyk-check 166f40b -> 30cc34c

Configuration

📅 Schedule: Branch creation - "* 21-23 * * 2,4" in timezone America/Toronto, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.

This PR has been generated by MintMaker (powered by Renovate Bot).

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/references/main branch from b49941b to 025ff4c Compare January 29, 2025 04:15
@red-hat-konflux red-hat-konflux bot requested a review from a team as a code owner January 29, 2025 04:15
Copy link

openshift-ci bot commented Jan 29, 2025

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron michael-valdron force-pushed the konflux/references/main branch from 175f9f6 to daebc58 Compare January 29, 2025 22:34
@michael-valdron
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added lgtm Looks good to me approved labels Jan 29, 2025
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@thepetk
Copy link
Contributor

thepetk commented Jan 30, 2025

@michael-valdron I'd rather not merge as you may have more context over the konflux migration

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, johnmcollier, red-hat-konflux[bot], thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,johnmcollier,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron
Copy link
Member

@michael-valdron I'd rather not merge as you may have more context over the konflux migration

@thepetk As per our discussion, I think as it stands right now the check passing and verifying there is no concerns in the Konflux pipeline logs is good enough to approve as a reviewer. In all cases I've seen so far the pipeline will fail if there is any problems with the setup.

Additionally you could verify that the image manifest is the latest one as of the review to reduce the chances of the EC check failing before the next patch schedule, every Tuesday and Thursday I have it set to. Since its Thursday, I think its fine to merge this now.

@thepetk thepetk merged commit b7c202f into main Jan 30, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants