Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styles:footer #38

Merged
merged 2 commits into from
Sep 6, 2024
Merged

styles:footer #38

merged 2 commits into from
Sep 6, 2024

Conversation

Frompaje
Copy link
Contributor

Closes #2

2024-08-28-16-44-26

@Luiginicoletti Luiginicoletti requested review from Luiginicoletti and removed request for Luiginicoletti August 30, 2024 14:11
Copy link
Member

@Luiginicoletti Luiginicoletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ficou top!!!

@aalmeida00 aalmeida00 merged commit ab14b1a into main Sep 6, 2024
2 of 3 checks passed
@RaulDelary
Copy link

@PiluVitu, esse PR foi mergeado com erro no build. Talvez seja legal alterar o ruleset da branch para permitir o merge apenas com todos os cheks ok e instruir os codeowners a não bypassar o merge 😄 .

See this.

Failed to compile.

./components/petdex/Footer/Footer.tsx
14:24  Error: Replace `bg-petdex-darkBlueSecondary·flex·w-full·items-center·justify-center` with `flex·w-full·items-center·justify-center·bg-petdex-darkBlueSecondary`  prettier/prettier
15:23  Error: Replace `text-petdex-primayWhite·w-full` with `w-full·text-petdex-primayWhite`  prettier/prettier
40:25  Error: Replace `border-petdex-primayWhite·mx-auto·border-t-[1px]` with `mx-auto·border-t-[1px]·border-petdex-primayWhite`  prettier/prettier

info  - Need to disable some ESLint rules? Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules
 ELIFECYCLE  Command failed with exit code 1.
Error: Process completed with exit code 1.

Em tempo, essas regras de lint fazem sentido? Se sim, acho interessante corrigir e tester novamente a demanda e fazer novo PR.

@PiluVitu
Copy link
Member

PiluVitu commented Sep 7, 2024

@PiluVitu, esse PR foi mergeado com erro no build. Talvez seja legal alterar o ruleset da branch para permitir o merge apenas com todos os cheks ok e instruir os codeowners a não bypassar o merge 😄 .

See this.

Failed to compile.

./components/petdex/Footer/Footer.tsx
14:24  Error: Replace `bg-petdex-darkBlueSecondary·flex·w-full·items-center·justify-center` with `flex·w-full·items-center·justify-center·bg-petdex-darkBlueSecondary`  prettier/prettier
15:23  Error: Replace `text-petdex-primayWhite·w-full` with `w-full·text-petdex-primayWhite`  prettier/prettier
40:25  Error: Replace `border-petdex-primayWhite·mx-auto·border-t-[1px]` with `mx-auto·border-t-[1px]·border-petdex-primayWhite`  prettier/prettier

info  - Need to disable some ESLint rules? Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules
 ELIFECYCLE  Command failed with exit code 1.
Error: Process completed with exit code 1.

Em tempo, essas regras de lint fazem sentido? Se sim, acho interessante corrigir e tester novamente a demanda e fazer novo PR.

Pior que está essa configuração se não me engano, vou dar uma olhada e ver o porquê disso acontecer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

footer
7 participants