refactor: rename setPadding to setSlideSideSpacing for clarity

devhatt · Aug 15, 2024 · caaf2b2 · caaf2b2
1 parent f122d95
commit caaf2b2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/components/Sliding/index.js b/src/components/Sliding/index.js
@@ -23,15 +23,16 @@ const html = `
 export default function Sliding({
   slides = [],
   shuffleMode = false,
-  sidePadding = 0,
+  slideSideSpacing = 0,
 }) {
   Component.call(this, { html, events });
   this.slideIndex = 0;
 
   slides.forEach((item) => this.add(item));
 
   this.setShuffleMode(shuffleMode);
-  if (slides.length > 1 && shuffleMode) this.setSidePadding(sidePadding);
+  if (slides.length > 1 && shuffleMode)
+    this.setSlideSideSpacing(slideSideSpacing);
 
   const $sliding = this.selected.get('sliding');
 
@@ -140,8 +141,9 @@ Sliding.prototype = Object.assign(Sliding.prototype, Component.prototype, {
     this.emit('slides:clear');
   },
 
-  setSidePadding(sidePadding = 0) {
-    this.selected.get('sliding-content').style.padding = `0 ${sidePadding}px`;
+  setSlideSideSpacing(slideSideSpacing = 0) {
+    this.selected.get('sliding-content').style.padding =
+      `0 ${slideSideSpacing}px`;
   },
 
   setShuffleMode(shuffleMode = false) {

diff --git a/src/stories/Sliding.stories.js b/src/stories/Sliding.stories.js
@@ -42,15 +42,15 @@ export default {
   },
   argsTypes: {
     slides: { control: 'object', defaultValue: [] },
-    sidePadding: { control: 'number', defaultValue: 0 },
+    slideSideSpacing: { control: 'number', defaultValue: 0 },
     shuffleMode: { control: 'boolean', defaultValue: false },
   },
 };
 
 export const Default = {
   args: {
     slides: [$slide1, $slide2, $slide3],
-    sidePadding: 60,
+    slideSideSpacing: 60,
     shuffleMode: true,
   },
 };