-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drawer component #191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cara sua qualidade de código é absurda de verdade, temos que lapidar umas paradas, mas ta lindo demais.
Ta faltando o story e os testes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ow seu css do Drawer ta muito bom, eu fui super preciosista na review, mas ta excelente de verdade, só fiz uns comentário pra melhorar ainda mais, mas não entenda errado, ta MUITO BOM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cara ta lindo, só queria uma explicação melhor da função de swipe
* feat: drawer component * fix: transition logic * fix: mobile drawer * chore: commitlint/cz-commitlint * feat: swipe animation for mobile * refactor: rip lil-x and lil-line, refactor improve code length * fix: minor changes * refactor: now emits change events * fix: if the screen is bigger than drawer component * fix: minor changes * fix: color drawer__title * fix: color name change * feat: transition drawer * fix: make compatible with new design * fix: content will have scroll bar if necessary * fix: prettier * fix: revert changes on prettierrc
…omponente (#203) * fix: adjusting input text position and padding * fix: changing homepage view back to default * feat: creating text input component * fix: adjusting input text colors to match with colors archive * fix: adjusting text input padding and position * fix: changing colors style to match with reference archive * feat: create text input storie * fix: adjusting padding and font to match with the reviews * fix: adding the correct color to the input text * fix: adjusting prefix and suffix common props * fix: removing test comment * feat: code-style (#213) Aproved by me, reclama dps * feat: drawer component (#191) * feat: drawer component * fix: transition logic * fix: mobile drawer * chore: commitlint/cz-commitlint * feat: swipe animation for mobile * refactor: rip lil-x and lil-line, refactor improve code length * fix: minor changes * refactor: now emits change events * fix: if the screen is bigger than drawer component * fix: minor changes * fix: color drawer__title * fix: color name change * feat: transition drawer * fix: make compatible with new design * fix: content will have scroll bar if necessary * fix: prettier * fix: revert changes on prettierrc * fix: resolve pnpm-lock conflicts * fix: slint error in scss archive --------- Co-authored-by: juliaM <35346206+juliaam@users.noreply.github.com> Co-authored-by: Rafael Lima <132157467+RafaelLimaC@users.noreply.github.com>
* feat: drawer component * fix: transition logic * fix: mobile drawer * chore: commitlint/cz-commitlint * feat: swipe animation for mobile * refactor: rip lil-x and lil-line, refactor improve code length * fix: minor changes * refactor: now emits change events * fix: if the screen is bigger than drawer component * fix: minor changes * fix: color drawer__title * fix: color name change * feat: transition drawer * fix: make compatible with new design * fix: content will have scroll bar if necessary * fix: prettier * fix: revert changes on prettierrc
…omponente (devhatt#203) * fix: adjusting input text position and padding * fix: changing homepage view back to default * feat: creating text input component * fix: adjusting input text colors to match with colors archive * fix: adjusting text input padding and position * fix: changing colors style to match with reference archive * feat: create text input storie * fix: adjusting padding and font to match with the reviews * fix: adding the correct color to the input text * fix: adjusting prefix and suffix common props * fix: removing test comment * feat: code-style (devhatt#213) Aproved by me, reclama dps * feat: drawer component (devhatt#191) * feat: drawer component * fix: transition logic * fix: mobile drawer * chore: commitlint/cz-commitlint * feat: swipe animation for mobile * refactor: rip lil-x and lil-line, refactor improve code length * fix: minor changes * refactor: now emits change events * fix: if the screen is bigger than drawer component * fix: minor changes * fix: color drawer__title * fix: color name change * feat: transition drawer * fix: make compatible with new design * fix: content will have scroll bar if necessary * fix: prettier * fix: revert changes on prettierrc * fix: resolve pnpm-lock conflicts * fix: slint error in scss archive --------- Co-authored-by: juliaM <35346206+juliaam@users.noreply.github.com> Co-authored-by: Rafael Lima <132157467+RafaelLimaC@users.noreply.github.com>
* feat: drawer component * fix: transition logic * fix: mobile drawer * chore: commitlint/cz-commitlint * feat: swipe animation for mobile * refactor: rip lil-x and lil-line, refactor improve code length * fix: minor changes * refactor: now emits change events * fix: if the screen is bigger than drawer component * fix: minor changes * fix: color drawer__title * fix: color name change * feat: transition drawer * fix: make compatible with new design * fix: content will have scroll bar if necessary * fix: prettier * fix: revert changes on prettierrc
Closes #118
Drawer component
Um componente de Drawer que abre da direita (ou de baixo em telas menores) e depois de fechado some da tela voltando por onde veio.
Visual evidences 🖼️
Checklist
Additional info
N/A