Issue 27 - Calendar component #219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alecell
suggested changes
May 9, 2024
src/components/Button/index.scss
Outdated
src/styles/colors.scss
Outdated
There was a problem hiding this comment.
As alteraçòes de cores tao certas aqui?
O Gray é Gray mesmo, nào é Grey
Alecell
reviewed
May 9, 2024
| @@ -0,0 +1,219 @@ | |||
| import { Component } from 'pet-dex-utilities'; | |||
| import './index.scss'; | |||
There was a problem hiding this comment.
Importar o css depois dos componentes
Alecell
reviewed
May 9, 2024
| @@ -0,0 +1,219 @@ | |||
| import { Component } from 'pet-dex-utilities'; | |||
| import './index.scss'; | |||
There was a problem hiding this comment.
Importar o css depois dos componentes
Alecell
suggested changes
May 9, 2024
| import { listenBreakpoint } from '../../../../utils/breakpoints/breakpoints'; | ||
| import DateButton from '../DateButton'; | ||
|
|
||
| const events = ['changeMonth', 'changeYear']; |
There was a problem hiding this comment.
Mudar o name pattern dos eventos
Comment on lines
27
to
28
| let handleTouchStart; | ||
| let handleTouchMove; |
Comment on lines
32
to
63
| handleTouchStart = (event) => { | ||
| startTouch = selector.isDesktop | ||
| ? event.touches[0].clientY | ||
| : event.touches[0].clientX; | ||
| }; | ||
|
|
||
| handleTouchMove = (event) => { | ||
| event.preventDefault(); | ||
| const currentTouch = selector.isDesktop | ||
| ? event.touches[0].clientY | ||
| : event.touches[0].clientX; | ||
| let move = 0; | ||
| const moveRange = 20; | ||
| move = currentTouch - startTouch; | ||
|
|
||
| if (Math.abs(move) > moveRange) { | ||
| const isSlideNext = move < 0; | ||
| const nextYear = +selector.dates[3].children[0].innerText; | ||
| const prevYear = +selector.dates[1].children[0].innerText; | ||
| const nextMonth = monthsBR.indexOf( | ||
| selector.dates[3].children[0].innerText, | ||
| ); | ||
| const prevMonth = monthsBR.indexOf( | ||
| selector.dates[1].children[0].innerText, | ||
| ); | ||
| if (isSlideNext && selector.isYear) selector.setYear(nextYear); | ||
| if (!isSlideNext && selector.isYear) selector.setYear(prevYear); | ||
| if (isSlideNext && !selector.isYear) selector.setMonth(nextMonth); | ||
| if (!isSlideNext && !selector.isYear) selector.setMonth(prevMonth); | ||
| startTouch = currentTouch; | ||
| } | ||
| }; |
There was a problem hiding this comment.
Toda essa parte do touchstart e touchmove deveria ser feita com o módulo atual de swipe, haviamos permitido deixar assim por enquanto pq a funcionalidade que precisavamos nao havia no modulo. Agora que será remanejado vamos revisitar isso e tentar usar o modulo de swipping.
| selector.dateSelector.addEventListener('touchmove', handleTouchMove); | ||
| } | ||
|
|
||
| let handleScroll; |
Comment on lines
69
to
95
| function scrollModal(selector) { | ||
| const $dateSelector = selector.dateSelector; | ||
|
|
||
| handleScroll = (event) => { | ||
| event.preventDefault(); | ||
| const isScrollNext = event.deltaY > 0; | ||
|
|
||
| if (selector.isYear) { | ||
| const nextYear = +selector.dates[3].children[0].innerText; | ||
| const prevYear = +selector.dates[1].children[0].innerText; | ||
| const newYear = isScrollNext ? nextYear : prevYear; | ||
| selector.setYear(newYear); | ||
| } else { | ||
| const nextMonth = monthsBR.indexOf( | ||
| selector.dates[3].children[0].innerText, | ||
| ); | ||
| const prevMonth = monthsBR.indexOf( | ||
| selector.dates[1].children[0].innerText, | ||
| ); | ||
| const newMonth = isScrollNext ? nextMonth : prevMonth; | ||
| selector.setMonth(newMonth); | ||
| } | ||
| }; | ||
|
|
||
| $dateSelector.addEventListener('wheel', handleScroll); | ||
| addTouchEvents(selector); | ||
| } |
There was a problem hiding this comment.
Isso aqui seria removido usando o slider
Comment on lines
139
to
145
| this.dateClickHandle = (index) => () => { | ||
| if (this.isYear) { | ||
| this.setYear(this.dateArray[index]); | ||
| } else { | ||
| this.setMonth(monthsBR.indexOf(this.dateArray[index])); | ||
| } | ||
| }; |
Comment on lines
158
to
164
| setTimeout(() => { | ||
| this.date.scrollIntoView({ | ||
| behavior: 'instant', | ||
| block: 'center', | ||
| inline: 'center', | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Acredito que tudo que ta feito aqui poderia ser dividido em mais funcionalidades, arquivos e funções
Comment on lines
182
to
200
| setMonth(newMonth) { | ||
| for (let i = 0; i < this.dateArray.length; i += 1) { | ||
| const index = (newMonth - (2 - i) + 12) % 12; | ||
| this.dateArray[i] = monthsBR[index]; | ||
| } | ||
|
|
||
| this.dateArray.forEach((item, index) => { | ||
| this.dates[index].children[0].innerText = item; | ||
| }); | ||
|
|
||
| this.date.scrollIntoView({ | ||
| behavior: 'instant', | ||
| block: 'center', | ||
| inline: 'center', | ||
| }); | ||
|
|
||
| this.emit('changeMonth', newMonth); | ||
| }, | ||
|
|
There was a problem hiding this comment.
Acredito que essa função ta complexa demais pra só trocar o mes
Comment on lines
201
to
218
| setYear(newYear) { | ||
| for (let i = 0; i < this.dateArray.length; i += 1) { | ||
| this.dateArray[i] = newYear - (2 - i); | ||
| } | ||
|
|
||
| this.dateArray.forEach((item, index) => { | ||
| this.dates[index].children[0].innerText = item; | ||
| }); | ||
|
|
||
| this.date.scrollIntoView({ | ||
| behavior: 'instant', | ||
| block: 'center', | ||
| inline: 'center', | ||
| }); | ||
|
|
||
| this.emit('changeYear', newYear); | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Acredito que essa funcao ta complexa demais pra so trocar o ano
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27
Feature
Criação do componente de calendário
Visual evidences 🖼️
calendar_component.mp4
Checklist
Additional info
Componente já estava criado mas tem alguns comentários do outro PR para resolver, eu resolvi alguns e abri esse PR para ser mais fácil de gerenciar os comentários. As cores não estão 100% certas, estou esperando a resposta do Desiger.