lopper:assists:baremetal_getsupported_comp_xlnx: Add support to inclu… #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @onkarharsh and @kedareswararao |
onkarharsh
reviewed
May 19, 2025
| @@ -46,7 +75,7 @@ def xlnx_baremetal_getsupported_comp(tgt_node, sdt, options): | |||
|
|
|||
| matched_node = get_cpu_node(sdt, options) | |||
| proc_ip_name = matched_node['xlnx,ip-name'].value[0] | |||
|
|
|||
| family = sdt.tree.dct['family'][0] | |||
There was a problem hiding this comment.
Try to use propval() if possible, that takes care of exceptions as well..
There was a problem hiding this comment.
Used propval() as suggested
sathishkumar-amd
force-pushed
the
lib_exmpl
branch
from
bd38fef to
2394fdc
Compare
onkarharsh
reviewed
May 21, 2025
| try: | ||
| exec(examples["condition"], {}, local_scope) | ||
| except Exception as e: | ||
| _error("The condition in the YAML file has failed. -> {e}") |
There was a problem hiding this comment.
Put this as a warning, not an error.
There was a problem hiding this comment.
Added warning as suggested
onkarharsh
reviewed
May 21, 2025
| exec(examples["condition"], {}, local_scope) | ||
| except Exception as e: | ||
| _error("The condition in the YAML file has failed. -> {e}") | ||
| examples = {key: value for key, value in examples.items() if key in local_scope["examples"]} |
There was a problem hiding this comment.
Move this examples under try block. If the condition fails, the old flow should still continue working.
There was a problem hiding this comment.
Updated code as suggested
onkarharsh
reviewed
May 21, 2025
| except Exception as e: | ||
| _error("The condition in the YAML file has failed. -> {e}") | ||
| examples = {key: value for key, value in examples.items() if key in local_scope["examples"]} | ||
| for ex,deps in examples.items(): |
There was a problem hiding this comment.
Delete "condition" key from examples before this loop to make old flow work.
onkarharsh
reviewed
May 21, 2025
| @@ -46,7 +75,7 @@ def xlnx_baremetal_getsupported_comp(tgt_node, sdt, options): | |||
|
|
|||
| matched_node = get_cpu_node(sdt, options) | |||
| proc_ip_name = matched_node['xlnx,ip-name'].value[0] | |||
|
|
|||
| family = sdt.tree['/'].propval('family')[0] | |||
There was a problem hiding this comment.
check the presence of index 0 element before processing,
onkarharsh
suggested changes
May 21, 2025
sathishkumar-amd
force-pushed
the
lib_exmpl
branch
from
2394fdc to
0221107
Compare
onkarharsh
suggested changes
May 21, 2025
| examples = {key: value for key, value in examples.items() if key in local_scope["examples"]} | ||
| except Exception as e: | ||
| _warning(f"The condition in the {yaml_file} file has failed. -> {e}") | ||
| examples = {key: value for key, value in examples.items() if key != "condition"} |
There was a problem hiding this comment.
examples.pop("condition", None) ?
…de the examples in the lib_list.yaml In the current implementation the examples are not included in the lib_list yaml file, Add support to include the examples in the lib_list.yaml to show the available examles for the library in the GUI. To enhance functionality, add support for reading examples from custom configurations in YAML files. If a YAML file contains a condition within the examples section in the form of a Python code block, read and execute this code to update the examples based on the specified conditions. This approach allows dynamic configuration adjustments based on predefined logic, improving flexibility and customization in managing examples Signed-off-by: Sathish Kumar Kamishettigari <sathishkumar.kamishettigari@amd.com>
sathishkumar-amd
force-pushed
the
lib_exmpl
branch
from
0221107 to
dceb74a
Compare
Updated the code as suggested |
onkarharsh
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…de the examples in the lib_list.yaml
In the current implementation the examples are not included in the lib_list yaml file, Add support to include the examples in the lib_list.yaml to show the available examles for the library in the GUI. To enhance functionality, add support for reading examples from custom configurations in YAML files. If a YAML file contains a condition within the examples section in the form of a Python code block, read and execute this code to update the examples based on the specified conditions. This approach allows dynamic configuration adjustments based on predefined logic, improving flexibility and customization in managing examples