chore: Playwright fix "Old Headless mode has been removed from the Chrome binary" #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterpeterparker
changed the title
AntonioVentilii
approved these changes
Jan 27, 2025
| @@ -25,7 +25,7 @@ const config: PlaywrightTestConfig = { | |||
| projects: [ | |||
| { | |||
| name: "Google Chrome", | |||
| use: { ...devices["Desktop Chrome"], channel: "chrome" }, | |||
| use: { ...devices["Desktop Chrome"], channel: "chromium" }, | |||
There was a problem hiding this comment.
I think "chronium" is the default, no?
There was a problem hiding this comment.
The linked resources on Playwright mention to explicitely change "chrome" to "chromium".
|
In NNS dapp, I fixed it by updating the playwright dependency: dfinity/nns-dapp#6207 |
Merged
|
Thanks. PR replaced by #568 which bumps Playwright |
peterpeterparker
deleted the
chore/fix-Old-Headless-mode-has-been-removed-from-the-Chrome-binary
branch
peterpeterparker
added a commit
that referenced
this pull request
Jan 27, 2025
# Motivation The E2E tests starts failing in the CI (see for example this [job](https://github.com/dfinity/gix-components/actions/runs/12982647342/job/36202745642?pr=548)). > pid=2146][err] Old Headless mode has been removed from the Chrome binary. Please use the new Headless mode (https://developer.chrome.com/docs/chromium/new-headless) or the chrome-headless-shell which is a standalone implementation of the old Headless mode (https://developer.chrome.com/blog/chrome-headless-shell). The issue can be resolved as in NNS dapp by bumping Playwright. See PR [#6207](dfinity/nns-dapp#6207) # Notes Replace PR #567 # Changes - Bump Playwright --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The E2E tests starts failing in the CI (see for example this job).
The reason and the solution is explained in this Playwright issue: microsoft/playwright#33566
Playwright documentation about Chromium: https://playwright.dev/docs/browsers#chromium
Issue I opened because I cannot run the Playwright command with the options: microsoft/playwright#34487
Changes
chromiumto download Chrome in the CI