Skip to content

Commit

Permalink
chore(IDX): group rust benchmark arguments (#3959)
Browse files Browse the repository at this point in the history
This moves all necessary arguments for running benchmarks into
`rust-benchmarks.sh`. This reduces complexity in the workflow file and
ensures `rust-benchmarks.sh` can be run without having to set any
environment variables.
  • Loading branch information
nmattia authored Feb 17, 2025
1 parent 20b675c commit 0d14522
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/schedule-rust-bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,8 @@ jobs:
id: rust-benchmarks
shell: bash
run: |
./ci/scripts/rust-benchmarks.sh
BAZEL_CI_CONFIG="--config=ci" ./ci/scripts/rust-benchmarks.sh
env:
BAZEL_CI_CONFIG: "--config=ci"
BAZEL_COMMAND: "run"
CI_JOB_URL: "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
RUST_BACKTRACE: "full"
TARGETS: ${{ matrix.targets }}
3 changes: 1 addition & 2 deletions ci/scripts/rust-benchmarks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ set -eEuo pipefail

TARGET_LIST=$(bazel query "attr(tags, 'rust_bench', ${TARGETS:-'//rs/...'})")
for TARGET in $TARGET_LIST; do
export BAZEL_TARGETS="$TARGET"
time ./ci/bazel-scripts/main.sh
BAZEL_COMMAND=run BAZEL_TARGETS="$TARGET" time ./ci/bazel-scripts/main.sh
done
find -L ./bazel-out -name 'benchmark.json'

Expand Down

0 comments on commit 0d14522

Please sign in to comment.