Skip to content

Commit

Permalink
chore(ICP-Ledger): remove node test (#2718)
Browse files Browse the repository at this point in the history
This MR proposes the following changes:

1. Remove the legacy test for ledger functionality when an NNS node is
added or removed

This test is no longer relevant as the functionality of nodes in the NNS
is thoroughly tested throughout the repository.
  • Loading branch information
NikolasHaimerl authored Nov 21, 2024
1 parent 27e7499 commit 2a7f5c9
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 222 deletions.
16 changes: 1 addition & 15 deletions rs/tests/financial_integrations/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("//rs/tests:common.bzl", "DEPENDENCIES", "GUESTOS_RUNTIME_DEPS", "MACRO_DEPENDENCIES", "UNIVERSAL_CANISTER_ENV", "UNIVERSAL_CANISTER_RUNTIME_DEPS")
load("//rs/tests:common.bzl", "DEPENDENCIES", "GUESTOS_RUNTIME_DEPS", "MACRO_DEPENDENCIES")
load("//rs/tests:system_tests.bzl", "system_test", "system_test_nns")

package(default_visibility = ["//rs:system-tests-pkg"])
Expand Down Expand Up @@ -39,20 +39,6 @@ system_test(
],
)

system_test_nns(
name = "token_fault_tolerance_test",
env = UNIVERSAL_CANISTER_ENV,
flaky = True,
proc_macro_deps = MACRO_DEPENDENCIES,
tags = [
"k8s",
"system_test_hourly",
],
target_compatible_with = ["@platforms//os:linux"], # requires libssh that does not build on Mac OS
runtime_deps = GUESTOS_RUNTIME_DEPS + UNIVERSAL_CANISTER_RUNTIME_DEPS,
deps = DEPENDENCIES + ["//rs/tests"],
)

system_test_nns(
name = "transaction_ledger_correctness_test",
flaky = True,
Expand Down
15 changes: 0 additions & 15 deletions rs/tests/financial_integrations/token_fault_tolerance_test.rs

This file was deleted.

1 change: 0 additions & 1 deletion rs/tests/src/ledger_tests/mod.rs
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
pub mod token_fault_tolerance;
pub mod transaction_ledger_correctness;
191 changes: 0 additions & 191 deletions rs/tests/src/ledger_tests/token_fault_tolerance.rs

This file was deleted.

0 comments on commit 2a7f5c9

Please sign in to comment.