Skip to content

Commit

Permalink
chore(EXC-1841): Remove old pmap canister (#4002)
Browse files Browse the repository at this point in the history
This is a very old canister using quite unsafe operations and it was
only added as part of the old COW implementation of Orthogonal
Persistence that we have long abandoned (and was never shipped to
production). Instead of fixing the TODO (that would basically require
switching the canister to use a saner approach wrt handling its state),
remove the canister as it doesn't seem to be used anywhere else.

---------

Co-authored-by: IDX GitHub Automation <infra+github-automation@dfinity.org>
  • Loading branch information
dsarlis and IDX GitHub Automation authored Feb 19, 2025
1 parent b9313f2 commit 5e72cad
Show file tree
Hide file tree
Showing 10 changed files with 0 additions and 235 deletions.
11 changes: 0 additions & 11 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,6 @@ members = [
"rs/rust_canisters/load_simulator",
"rs/rust_canisters/memory_test",
"rs/rust_canisters/on_wire",
"rs/rust_canisters/pmap",
"rs/rust_canisters/proxy_canister",
"rs/rust_canisters/response_payload_test",
"rs/rust_canisters/stable_reader",
Expand Down
1 change: 0 additions & 1 deletion rs/coverage.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
"registry-canister", # Run from wrong directory
"rust-canister-tests", # Runs too slow
"ledger-canister", # Runs too slow
"pmap", # Can not be compiled natively
"dfn_core", # Can not be compiled natively
]

Expand Down
55 changes: 0 additions & 55 deletions rs/rust_canisters/pmap/BUILD.bazel

This file was deleted.

31 changes: 0 additions & 31 deletions rs/rust_canisters/pmap/Cargo.toml

This file was deleted.

3 changes: 0 additions & 3 deletions rs/rust_canisters/pmap/Readme.md

This file was deleted.

88 changes: 0 additions & 88 deletions rs/rust_canisters/pmap/canister/main.rs

This file was deleted.

7 changes: 0 additions & 7 deletions rs/rust_canisters/pmap/canister/pmap.did

This file was deleted.

1 change: 0 additions & 1 deletion rs/rust_canisters/pmap/src/main.rs

This file was deleted.

37 changes: 0 additions & 37 deletions rs/rust_canisters/pmap/test/main.rs

This file was deleted.

0 comments on commit 5e72cad

Please sign in to comment.