Skip to content

Commit

Permalink
Remove unnecessary || return statements
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewbattat committed Feb 18, 2025
1 parent 9ff9ad1 commit 89901d1
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions ic-os/components/setupos-scripts/check-network.sh
Original file line number Diff line number Diff line change
Expand Up @@ -149,20 +149,20 @@ function validate_domain_name() {
IFS='.' read -ra domain_parts <<<"${domain_name}"

if [ ${#domain_parts[@]} -lt 2 ]; then
log_and_halt_installation_on_error 1 "Domain validation error: less than two domain parts in domain: ${domain_name}" || return $?
log_and_halt_installation_on_error 1 "Domain validation error: less than two domain parts in domain: ${domain_name}"
fi

for domain_part in "${domain_parts[@]}"; do
if [ -z "$domain_part" ] || [ ${#domain_part} -gt 63 ]; then
log_and_halt_installation_on_error 1 "Domain validation error: domain part length violation: ${domain_part}" || return $?
log_and_halt_installation_on_error 1 "Domain validation error: domain part length violation: ${domain_part}"
fi

if [[ $domain_part == -* ]] || [[ $domain_part == *- ]]; then
log_and_halt_installation_on_error 1 "Domain validation error: domain part starts or ends with a hyphen: ${domain_part}" || return $?
log_and_halt_installation_on_error 1 "Domain validation error: domain part starts or ends with a hyphen: ${domain_part}"
fi

if ! [[ $domain_part =~ ^[a-zA-Z0-9-]+$ ]]; then
log_and_halt_installation_on_error 1 "Domain validation error: invalid characters in domain part: ${domain_part}" || return $?
log_and_halt_installation_on_error 1 "Domain validation error: invalid characters in domain part: ${domain_part}"
fi
done
}
Expand Down

0 comments on commit 89901d1

Please sign in to comment.