feat(node): Configuration revamp (GuestOS integration) #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbattat
changed the title
andrewbattat
commented
Sep 25, 2024
andrewbattat
commented
Oct 3, 2024
andrewbattat
commented
Oct 4, 2024
ic-os/components/hostos-scripts/generate-guestos-config/generate-guestos-config.sh
Outdated
Show resolved
Hide resolved
andrewbattat
commented
Oct 4, 2024
andrewbattat
commented
Oct 7, 2024
ic-os/components/early-boot/setup-hostname/hostos/setup-hostname.sh
Outdated
Show resolved
Hide resolved
|
Passing hourly: https://github.com/dfinity/ic/actions/runs/12284931379 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
- Add a check in update-config preventing a "new" testnet config from being overwritten. This check fixes errors in the [config revamp](#1563) caused by update-config erroneously overriding development config fields. This change will have no impact on mainnet: cf825d2 - Allowing an empty hostname field in GuestOS fixes update-config errors in the nested tests. Example: https://github.com/dfinity/ic/actions/runs/12244488249 The hostname field will always be populated on mainnet, so this will only impact testing: 764230f - Switching nested testing to run with a "testnet" deployment environment (54cde2e, 23d8824) fixes issues with deployment configs being overwritten.
andrewbattat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NODE-1545
The IC-OS tool has been created, but not yet used by the IC-OS: #1539
This PR integrates the config tool into the IC-OS. The config tool is utilized for config sanitization, organization, access, and propagation (note that some propagation and access is still done in bash scripts).
Once we are happy with the new design, we will rollout an update-config service to convert the old config to the new config (recall that config persists between upgrades and reboots), the SetupOS integration portion, and then we will roll out the HostOS and GuestOS integration.