refactor(NODE-1484): refactor os_tools and networking code #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbattat
changed the title
andrewbattat
changed the title
Bownairo
reviewed
Sep 26, 2024
andrewbattat
changed the title
andrewbattat
changed the title
andrewbattat
commented
Sep 26, 2024
andrewbattat
deleted the
andrew/refactor-generate_network_config-mgmt_mac
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NODE-1484
Move the mgmt_mac conditional from generate_mac_address to the os_tool top level. This reduces the responsibility of generate_network_config and this change means we aren't passing optionals far down the stack (mgmt_mac, deployment_name). And this change makes it more clear that mgmt_mac is a branch for testing logic.