feat: [MR-354] Load & validate protos asynchronously #2594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Stefan Schneider <31004026+schneiderstefan@users.noreply.github.com>
pakhomov-dfinity
changed the title
ShuoWangNSL
reviewed
Jan 23, 2025
ShuoWangNSL
reviewed
Jan 23, 2025
ShuoWangNSL
reviewed
Jan 23, 2025
schneiderstefan
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of the asynchronous checkpointing, we move reading protos to the Tip thread.
Currently we have the ReplicatedState from execution, serialize it into a checkpoint, load back the checkpoint in order to ensure it's loadable and equivalent to the original one, use the loaded checkpoint to switch the file descriptors in the original state to point to the new files.
The protos are only used for validation and at replica init.
With this change we do loading and validation away from the critical path.