fix: use api boundary nodes as socks proxies #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumenov
reviewed
Nov 20, 2024
rumenov
reviewed
Dec 16, 2024
rumenov
reviewed
Dec 16, 2024
r-birkner
reviewed
Dec 16, 2024
r-birkner
reviewed
Dec 16, 2024
r-birkner
reviewed
Dec 16, 2024
r-birkner
reviewed
Dec 16, 2024
r-birkner
reviewed
Dec 16, 2024
r-birkner
reviewed
Dec 16, 2024
r-birkner
approved these changes
Dec 16, 2024
r-birkner
reviewed
Dec 16, 2024
rumenov
reviewed
Jan 20, 2025
rumenov
reviewed
Jan 21, 2025
rumenov
reviewed
Jan 21, 2025
rumenov
reviewed
Jan 21, 2025
rumenov
reviewed
Jan 21, 2025
rumenov
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2191 creates socks proxies on API Boundary Nodes.
This PR fetches all of the API Boundary Nodes IPs through registry for each https outcalls request batch and sends them to the adapter. The adapter uses one of these IPs as SOCKS Proxy (if needed), at random, with a maximum of 3 retries.
This is a dark launch; still using the old boundary nodes as socks proxies, and comparing the results with results coming through the new api boundary nodes.
As bandwidth could go up drastically, we only perform dark launch comparisons on a small percentage of requests. That percentage is currently set to 0.