Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IC-1680] Add registry data provider for canisters #2783

Merged
merged 24 commits into from
Dec 20, 2024

Conversation

pietrodimarco-dfinity
Copy link
Contributor

@pietrodimarco-dfinity pietrodimarco-dfinity commented Nov 22, 2024

This registry data provider is designed to work with the ic-registry-canister-client
in canisters, enabling the retrieval and storage of a registry copy in stable memory.

  • If keys_to_keep is Some(keys), only the specified keys will be stored in stable memory,
    while all other keys from the registry will be discarded.
  • If keys_to_keep is None, all keys from the registry will be retained in stable memory.

@pietrodimarco-dfinity pietrodimarco-dfinity requested a review from a team as a code owner November 22, 2024 23:40
@pietrodimarco-dfinity pietrodimarco-dfinity marked this pull request as draft November 22, 2024 23:40
@pietrodimarco-dfinity pietrodimarco-dfinity changed the title Add stable mem registry data provider feat: IC-1680: Add stable structures registry data provider Nov 26, 2024
@github-actions github-actions bot added the feat label Nov 26, 2024
@pietrodimarco-dfinity pietrodimarco-dfinity marked this pull request as ready for review November 26, 2024 14:40
@pietrodimarco-dfinity pietrodimarco-dfinity changed the title feat: IC-1680: Add stable structures registry data provider feat: IC-1680: Add registry data provider for canisters Nov 26, 2024
@sasa-tomic sasa-tomic changed the title feat: IC-1680: Add registry data provider for canisters feat: [IC-1680] Add registry data provider for canisters Nov 26, 2024
@max-dfinity max-dfinity self-requested a review November 27, 2024 02:04
Copy link
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pietrodimarco-dfinity pietrodimarco-dfinity added this pull request to the merge queue Dec 20, 2024
Merged via the queue into master with commit 9d02e69 Dec 20, 2024
25 checks passed
@pietrodimarco-dfinity pietrodimarco-dfinity deleted the pmarco/add-stable-data-provider branch December 20, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants