-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [IC-1680] Add registry data provider for canisters #2783
Merged
pietrodimarco-dfinity
merged 24 commits into
master
from
pmarco/add-stable-data-provider
Dec 20, 2024
Merged
feat: [IC-1680] Add registry data provider for canisters #2783
pietrodimarco-dfinity
merged 24 commits into
master
from
pmarco/add-stable-data-provider
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into pmarco/add-stable-data-provider
… into pmarco/add-stable-data-provider
sasa-tomic
reviewed
Nov 26, 2024
sasa-tomic
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
max-dfinity
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This registry data provider is designed to work with the
ic-registry-canister-client
in canisters, enabling the retrieval and storage of a registry copy in stable memory.
keys_to_keep
isSome(keys)
, only the specifiedkeys
will be stored in stable memory,while all other keys from the registry will be discarded.
keys_to_keep
isNone
, all keys from the registry will be retained in stable memory.