Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ckbtc): add metrics for the latency of update_balance in the minter #3003

Merged
merged 12 commits into from
Dec 12, 2024
Merged

chore(ckbtc): add metrics for the latency of update_balance in the minter #3003

merged 12 commits into from
Dec 12, 2024

Conversation

lpahlavi
Copy link
Contributor

@lpahlavi lpahlavi commented Dec 6, 2024 •
edited by jira bot
Loading

(XC-235) Add metrics to monitor the latency of the update_balance method in the ckBTC minter.

@github-actions github-actions bot added the chore label Dec 6, 2024
@lpahlavi lpahlavi added CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 and removed chore labels Dec 6, 2024
@lpahlavi lpahlavi force-pushed the lpahlavi/XC-235-ckbtc-minter-update-balance-metric branch from 71369ef to 6d0d683 Compare December 6, 2024 15:25
@github-actions github-actions bot added the chore label Dec 6, 2024
@lpahlavi lpahlavi marked this pull request as ready for review December 6, 2024 15:47
@lpahlavi lpahlavi requested a review from a team as a code owner December 6, 2024 15:47
gregorydemay
gregorydemay reviewed Dec 9, 2024
View reviewed changes
Copy link
Member

@gregorydemay gregorydemay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lpahlavi for this PR!. I think you're going in the right direction. One comment is that I would have a latency histogram for a given number of processable UTXOs.

gregorydemay
gregorydemay reviewed Dec 10, 2024
View reviewed changes
Copy link
Member

@gregorydemay gregorydemay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! I have a comment regarding using adaptive ranges but it can be done here or as a separate PR, as you wish.

gregorydemay
gregorydemay approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@gregorydemay gregorydemay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lpahlavi for this PR!

@lpahlavi lpahlavi requested a review from ninegua December 12, 2024 09:20
@lpahlavi @gregorydemay
Update rs/bitcoin/ckbtc/minter/src/updates/tests.rs
2d5b2d3 
Co-authored-by: gregorydemay <112856886+gregorydemay@users.noreply.github.com>
ninegua
ninegua approved these changes Dec 12, 2024
View reviewed changes
@lpahlavi lpahlavi enabled auto-merge December 12, 2024 10:06
@lpahlavi lpahlavi added this pull request to the merge queue Dec 12, 2024
Merged via the queue into master with commit db8c33d Dec 12, 2024
25 checks passed
@lpahlavi lpahlavi deleted the lpahlavi/XC-235-ckbtc-minter-update-balance-metric branch December 12, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninegua ninegua ninegua approved these changes

@gregorydemay gregorydemay gregorydemay approved these changes

Assignees
No one assigned
Labels
chore CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 @cross-chain-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lpahlavi @ninegua @gregorydemay