Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cketh): add pagination to minter dashboard #3046

Merged
merged 7 commits into from
Dec 13, 2024

Conversation

lpahlavi
Copy link
Contributor

@lpahlavi lpahlavi commented Dec 9, 2024

(XC-240) Add pagination to the ckETH minter dashboard.

@github-actions github-actions bot added the feat label Dec 9, 2024
@lpahlavi lpahlavi changed the title feat(ckETH): add pagination to minter dashboard chore(ckETH): add pagination to minter dashboard Dec 9, 2024
@github-actions github-actions bot added chore and removed feat labels Dec 9, 2024
@lpahlavi lpahlavi added the CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 label Dec 9, 2024
@lpahlavi lpahlavi force-pushed the lpahlavi/xc-240-add-pagination-to-cketh-dashboard branch from 6730df5 to d3b9e59 Compare December 11, 2024 14:15
@lpahlavi lpahlavi force-pushed the lpahlavi/xc-240-add-pagination-to-cketh-dashboard branch from d3b9e59 to 0021a30 Compare December 11, 2024 15:10
@lpahlavi lpahlavi marked this pull request as ready for review December 12, 2024 07:40
@lpahlavi lpahlavi requested a review from a team as a code owner December 12, 2024 07:40
Copy link
Member

@gregorydemay gregorydemay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lpahlavi for this PR. I have some minor comments but otherwise LGTM! Before merging, we should deploy it on the Sepolia minter to see if everything is as expected.

@lpahlavi lpahlavi changed the title chore(ckETH): add pagination to minter dashboard chore(cketh): add pagination to minter dashboard Dec 13, 2024
@lpahlavi lpahlavi added this pull request to the merge queue Dec 13, 2024
Merged via the queue into master with commit 5368bae Dec 13, 2024
27 checks passed
@lpahlavi lpahlavi deleted the lpahlavi/xc-240-add-pagination-to-cketh-dashboard branch December 13, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 @cross-chain-team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants