-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cketh): add pagination to minter dashboard #3046
Merged
lpahlavi
merged 7 commits into
master
from
lpahlavi/xc-240-add-pagination-to-cketh-dashboard
Dec 13, 2024
Merged
chore(cketh): add pagination to minter dashboard #3046
lpahlavi
merged 7 commits into
master
from
lpahlavi/xc-240-add-pagination-to-cketh-dashboard
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6730df5
to
d3b9e59
Compare
d3b9e59
to
0021a30
Compare
gregorydemay
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lpahlavi for this PR. I have some minor comments but otherwise LGTM! Before merging, we should deploy it on the Sepolia minter to see if everything is as expected.
ninegua
reviewed
Dec 13, 2024
ninegua
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(XC-240) Add pagination to the ckETH minter dashboard.