perf(nns): Add benchmarks for neuron data validator #3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonz-dfinity
force-pushed
the
jason/NNS1-3475-1
branch
from
0b20cdf to
d61eb16
Compare
max-dfinity
approved these changes
Dec 11, 2024
jasonz-dfinity
force-pushed
the
jason/NNS1-3475-1
branch
from
d61eb16 to
4b47e22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Neuron data validator goes through batches of neurons in order to make sure neurons and its indexes are in a consistent state, and such operations will get more expensive after neurons are migrated to stable structures. Adding benchmarks makes it easier to optimize the performance, and help prevent regressions.
What
Add benchmarks for neuron data validator for 2 cases - whether the neuron migration to stable structures is enabled or not.