perf(nns): Read heap neurons for cardinalities #3103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The method
with_active_neurons_iter
is much more expensive than readingheap_neurons
directly. In the context of neuron data validation, it's unnecessary to usewith_active_neurons_iter
since it reads both heap and stable memories. In other words, it readsheap_neurons
not for "active neurons" but really just the neurons in the heap.What
Revert to using
heap_neurons_iter
and update benchmarks