perf(nns): Improve neuron validation batching #3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonz-dfinity
force-pushed
the
jason/NNS1-3475-4
branch
from
2f396b5 to
6b7eb11
Compare
max-dfinity
approved these changes
Dec 11, 2024
jasonz-dfinity
force-pushed
the
jason/NNS1-3475-3
branch
from
e86ad57 to
6dd4ab6
Compare
jasonz-dfinity
force-pushed
the
jason/NNS1-3475-4
branch
from
6b7eb11 to
9182954
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently, the neuron data validation is reading all neuron sections for a batch of neurons, and the batching is by a fixed batch size. Those can be improved by: reading specific neuron sections for each task, and batch by instruction limit.
What
Implement the above-mentioned optimizations and update benchmarks.