-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sns): Automatically advance SNS target version upon opt-in #3119
Conversation
One possibility would be to have a staged rollout by default (e.g. only a 1% chance per refresh of setting the target version). This would mean that we'd have some time to stop the release if we start noticing problems. I think staged rollouts are a common practice for this reason. |
1bf7dda
to
1d9692a
Compare
I think that would complicate the feature too much in this case. In the unlikely event of a critical bug that goes through NNS blessing, an SNS that opted in for this feature would need to pass another proposal to opt out of it, and then it could regain manual control again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
This PR implements a simple extension of the AdvanceSnsTargetVersion mechanism, allowing SNSs to opt-in for getting target versions advanced to the latest available SNS version blessed by the NNS community.