Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sns): Automatically advance SNS target version upon opt-in #3119

Merged
merged 6 commits into from
Jan 22, 2025

Conversation

aterga
Copy link
Member

@aterga aterga commented Dec 11, 2024

This PR implements a simple extension of the AdvanceSnsTargetVersion mechanism, allowing SNSs to opt-in for getting target versions advanced to the latest available SNS version blessed by the NNS community.

@github-actions github-actions bot added the feat label Dec 11, 2024
@anchpop
Copy link
Contributor

anchpop commented Dec 11, 2024

One possibility would be to have a staged rollout by default (e.g. only a 1% chance per refresh of setting the target version). This would mean that we'd have some time to stop the release if we start noticing problems. I think staged rollouts are a common practice for this reason.

@aterga aterga force-pushed the arshavir/sns-upgrade-automation branch from 1bf7dda to 1d9692a Compare January 16, 2025 14:21
@aterga
Copy link
Member Author

aterga commented Jan 16, 2025

One possibility would be to have a staged rollout by default (e.g. only a 1% chance per refresh of setting the target version). This would mean that we'd have some time to stop the release if we start noticing problems. I think staged rollouts are a common practice for this reason.

I think that would complicate the feature too much in this case. In the unlikely event of a critical bug that goes through NNS blessing, an SNS that opted in for this feature would need to pass another proposal to opt out of it, and then it could regain manual control again.

@aterga aterga marked this pull request as ready for review January 16, 2025 14:48
@aterga aterga requested a review from a team as a code owner January 16, 2025 14:48
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).

To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:

  1. Done.

  2. No canister behavior changes.

@aterga aterga added this pull request to the merge queue Jan 22, 2025
Merged via the queue into master with commit 1edf4a1 Jan 22, 2025
27 checks passed
@aterga aterga deleted the arshavir/sns-upgrade-automation branch January 22, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants