Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "feat: [EXC-1753] Add mint_cycles128 API" #3125

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

cgundy
Copy link
Member

@cgundy cgundy commented Dec 11, 2024

Reverts #2589

@cgundy cgundy changed the title Revert "feat: [EXC-1753] Add mint_cycles128 API" Revert: "feat: [EXC-1753] Add mint_cycles128 API" Dec 11, 2024
@cgundy cgundy added the CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 label Dec 11, 2024
@cgundy cgundy closed this Dec 11, 2024
@cgundy cgundy reopened this Dec 11, 2024
@cgundy cgundy changed the title Revert: "feat: [EXC-1753] Add mint_cycles128 API" revert: "feat: [EXC-1753] Add mint_cycles128 API" Dec 11, 2024
@cgundy cgundy marked this pull request as ready for review December 11, 2024 16:09
@cgundy cgundy requested a review from a team as a code owner December 11, 2024 16:09
@cgundy cgundy enabled auto-merge December 11, 2024 16:11
@cgundy cgundy added this pull request to the merge queue Dec 11, 2024
Merged via the queue into master with commit df65369 Dec 11, 2024
41 of 60 checks passed
@cgundy cgundy deleted the revert-2589-mwe/cycles128 branch December 11, 2024 18:19
@michael-weigelt michael-weigelt restored the revert-2589-mwe/cycles128 branch December 12, 2024 12:43
@michael-weigelt michael-weigelt deleted the revert-2589-mwe/cycles128 branch December 12, 2024 12:44
@michael-weigelt michael-weigelt mentioned this pull request Dec 12, 2024
michael-weigelt added a commit that referenced this pull request Dec 12, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 13, 2024
)

#2589 caused a problem in a backup
test in the hourly pipeline, so it was reverted in #3125.

#3147 addressed the underlying problem
in the backup test and was merged.
#3151 is 2589+3147 and shows that the
mitigation works, but instead of merging that, it's nicer to revert the
revert:

This PR reverts #3125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 @execution revert
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants