refactor(Consensus): Factor CUP functionality out of dkg submodule #3126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
@ic-message-routing-owners
@pocket-ic
@networking
@consensus
labels
schneiderstefan
approved these changes
Dec 11, 2024
mraszyk
approved these changes
Dec 11, 2024
rumenov
approved these changes
Dec 12, 2024
eichhorl
approved these changes
Dec 12, 2024
Co-authored-by: Leo Eichhorn <99166915+eichhorl@users.noreply.github.com>
daniel-wong-dfinity-org
pushed a commit
that referenced
this pull request
Jan 7, 2025
…3126) The functions `make_registry_cup` and `make_registry_cup_from_cup` are used by other crates to create registry CUPs. This PR moves the functions out of the `dkg` submodule into its own module `cup_utils` and directly exports them from the top-level `ic_consensus`. The reason is that these functions also use `idkg` functionality. --------- Co-authored-by: Leo Eichhorn <99166915+eichhorl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions
make_registry_cupandmake_registry_cup_from_cupare used by other crates to create registry CUPs.This PR moves the functions out of the
dkgsubmodule into its own modulecup_utilsand directly exports them from the top-levelic_consensus.The reason is that these functions also use
idkgfunctionality.