Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: runner #3129

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
+15 −23
Draft

test: runner #3129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
49bef9c
test: runner
marko-k0 Dec 11, 2024
d21e1fc
IDX GitHub Automation
Dec 11, 2024
93e0fa4
test
marko-k0 Dec 12, 2024
6bab682
IDX GitHub Automation
Dec 12, 2024
7895387
test
marko-k0 Dec 12, 2024
4802d61
IDX GitHub Automation
Dec 12, 2024
e9b8a42
test
marko-k0 Dec 12, 2024
c5cf8f3
test
marko-k0 Dec 12, 2024
f57fdbb
IDX GitHub Automation
Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .github/workflows-source/ci-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ anchors:
image: ghcr.io/dfinity/ic-build@sha256:4fd13b47285e783c3a6f35aadd9559d097c0de162a1cf221ead66ab1598d5d45
dind-large-setup: &dind-large-setup
runs-on:
labels: dind-large
labels: dind-test
container:
<<: *image
options: >-
-e NODE_NAME
--privileged --cgroupns host
--privileged --cgroupns host --network host
-v /cache:/cache -v /var/sysimage:/var/sysimage -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info
timeout-minutes: 90
dind-small-setup: &dind-small-setup
Expand Down Expand Up @@ -94,9 +94,6 @@ jobs:
bazel-test-all:
name: Bazel Test All
<<: *dind-large-setup
runs-on:
group: zh1
labels: dind-large
env:
AWS_SHARED_CREDENTIALS_CONTENT: ${{ secrets.AWS_SHARED_CREDENTIALS_FILE }}
# Only run ci/bazel-scripts/diff.sh on PRs that are not labeled with "CI_ALL_BAZEL_TARGETS".
Expand Down Expand Up @@ -263,9 +260,6 @@ jobs:
name: Build IC
<<: *dind-large-setup
# keep options from dind-large-setup but run on dind-small-setup
runs-on:
group: ch1
labels: dind-small
if: ${{ github.event_name != 'merge_group' }}
steps:
- <<: *checkout
Expand Down
26 changes: 12 additions & 14 deletions .github/workflows/ci-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,13 @@ env:
jobs:
bazel-test-all:
name: Bazel Test All
runs-on:
labels: dind-test
container:
image: ghcr.io/dfinity/ic-build@sha256:4fd13b47285e783c3a6f35aadd9559d097c0de162a1cf221ead66ab1598d5d45
options: >-
-e NODE_NAME --privileged --cgroupns host -v /cache:/cache -v /var/sysimage:/var/sysimage -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info
-e NODE_NAME --privileged --cgroupns host --network host -v /cache:/cache -v /var/sysimage:/var/sysimage -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info
timeout-minutes: 90
runs-on:
group: zh1
labels: dind-large
env:
AWS_SHARED_CREDENTIALS_CONTENT: ${{ secrets.AWS_SHARED_CREDENTIALS_FILE }}
# Only run ci/bazel-scripts/diff.sh on PRs that are not labeled with "CI_ALL_BAZEL_TARGETS".
Expand Down Expand Up @@ -125,11 +124,11 @@ jobs:
bazel-targets
bazel-build-all-config-check:
runs-on:
labels: dind-large
labels: dind-test
container:
image: ghcr.io/dfinity/ic-build@sha256:4fd13b47285e783c3a6f35aadd9559d097c0de162a1cf221ead66ab1598d5d45
options: >-
-e NODE_NAME --privileged --cgroupns host -v /cache:/cache -v /var/sysimage:/var/sysimage -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info
-e NODE_NAME --privileged --cgroupns host --network host -v /cache:/cache -v /var/sysimage:/var/sysimage -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info
timeout-minutes: 90
name: Bazel Build All Config Check
if: ${{ contains(github.event.pull_request.labels.*.name, 'CI_BUILD_CHECK') }}
Expand Down Expand Up @@ -219,11 +218,11 @@ jobs:
bazel-build-fuzzers:
name: Bazel Build Fuzzers
runs-on:
labels: dind-large
labels: dind-test
container:
image: ghcr.io/dfinity/ic-build@sha256:4fd13b47285e783c3a6f35aadd9559d097c0de162a1cf221ead66ab1598d5d45
options: >-
-e NODE_NAME --privileged --cgroupns host -v /cache:/cache -v /var/sysimage:/var/sysimage -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info
-e NODE_NAME --privileged --cgroupns host --network host -v /cache:/cache -v /var/sysimage:/var/sysimage -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info
timeout-minutes: 90
steps:
- name: Checkout
Expand Down Expand Up @@ -254,11 +253,11 @@ jobs:
bazel-build-fuzzers-afl:
name: Bazel Build Fuzzers AFL
runs-on:
labels: dind-large
labels: dind-test
container:
image: ghcr.io/dfinity/ic-build@sha256:4fd13b47285e783c3a6f35aadd9559d097c0de162a1cf221ead66ab1598d5d45
options: >-
-e NODE_NAME --privileged --cgroupns host -v /cache:/cache -v /var/sysimage:/var/sysimage -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info
-e NODE_NAME --privileged --cgroupns host --network host -v /cache:/cache -v /var/sysimage:/var/sysimage -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info
timeout-minutes: 90
steps:
- name: Checkout
Expand Down Expand Up @@ -320,15 +319,14 @@ jobs:
REPO_NAME: ${{ github.repository }}
build-ic:
name: Build IC
runs-on:
labels: dind-test
container:
image: ghcr.io/dfinity/ic-build@sha256:4fd13b47285e783c3a6f35aadd9559d097c0de162a1cf221ead66ab1598d5d45
options: >-
-e NODE_NAME --privileged --cgroupns host -v /cache:/cache -v /var/sysimage:/var/sysimage -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info
-e NODE_NAME --privileged --cgroupns host --network host -v /cache:/cache -v /var/sysimage:/var/sysimage -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info
timeout-minutes: 90
# keep options from dind-large-setup but run on dind-small-setup
runs-on:
group: ch1
labels: dind-small
if: ${{ github.event_name != 'merge_group' }}
steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion rs/replica/src/setup.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ use ic_types::{
};
use std::{env, path::PathBuf, sync::Arc};

/// Parse command-line args into `ReplicaArgs`
/// Parse command-line args into `ReplicaArgs` misc
pub fn parse_args() -> Result<ReplicaArgs, clap::Error> {
let args_result = ReplicaArgs::try_parse_from(env::args());

Expand Down
Loading