chore: Update ic-agent and ic-agent's reverse dependencies to v0.39 #3282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchpop
force-pushed
the
@anchpop/update-crate-versions
branch
from
1b2ffd0 to
1289183
Compare
anchpop
force-pushed
the
@anchpop/update-crate-versions
branch
from
c04cbfc to
7fe8cbc
Compare
anchpop
force-pushed
the
@anchpop/update-crate-versions
branch
18 times, most recently
from
db85b04 to
ec17eb9
Compare
anchpop
force-pushed
the
@anchpop/update-crate-versions
branch
6 times, most recently
from
984b7af to
029c50c
Compare
anchpop
changed the title
|
@nikolay-komarevskiy : could you take a look at the failing test? I wasn't able to figure out what's breaking it :( |
r-birkner
approved these changes
Jan 5, 2025
@anchpop Thanks a lot for doing a very valuable effort of updating this dependency! |
mbjorkqvist
approved these changes
Jan 6, 2025
dsarlis
approved these changes
Jan 6, 2025
mraszyk
reviewed
Jan 6, 2025
venkkatesh-sekar
approved these changes
Jan 6, 2025
aterga
approved these changes
Jan 6, 2025
nmattia
approved these changes
Jan 6, 2025
mraszyk
approved these changes
Jan 6, 2025
anchpop
changed the title
anchpop
force-pushed
the
@anchpop/update-crate-versions
branch
from
db9ed03 to
febda61
Compare
daniel-wong-dfinity-org
pushed a commit
that referenced
this pull request
Jan 7, 2025
…3282) I created this PR by following these instructions from @nathanosdev: > The following crates should use version 3.0.2: > 1. `ic-response-verification` > 2. `ic-certification` > 3. `ic-certificate-verification` > 4. `ic-http-certification` > 5. `ic-cbor` > > I recommend just setting them to `3` in `Cargo.toml` and `^3.0.2` in `external_crates.bzl` so they can be updated more easily in the future. That's how it's setup in `ic-http-gateway` too. > And `ic-http-gateway` can be set to version `0.1.0`. The git tag reference can be removed now. I also updated `ic-agent` to 0.39 because that is the version of `ic-agent` that `ic-http-gateway` v0.1.0 depends on. In doing so, I also updated `ic-utils` and `ic-transport-types`. I also moved the `ic-http-gateway` dependency to the workspace-level `Cargo.toml`. It seems like there were a number of breaking changes in these crates, so I also went through and fixed all the code that became broken. --------- Co-authored-by: IDX GitLab Automation <idx@dfinity.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this PR by following these instructions from @nathanosdev:
I also updated
ic-agentto 0.39 because that is the version ofic-agentthatic-http-gatewayv0.1.0 depends on. In doing so, I also updatedic-utilsandic-transport-types. I also moved theic-http-gatewaydependency to the workspace-levelCargo.toml.It seems like there were a number of breaking changes in these crates, so I also went through and fixed all the code that became broken.