-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sns): Enable upgrading SNS-controlled canisters using chunked WASMs #3287
feat(sns): Enable upgrading SNS-controlled canisters using chunked WASMs #3287
Conversation
534ea16
to
49f5888
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
TODO: Extend the rs/nervous_system/integration_tests/tests/upgrade_sns_controlled_canister_with_large_wasm.rs test to submit a proposal that would tirgger the upgrade. Done |
I think you need to modify the second example in your PR description? It lists chunks, but IIUC, the idea is that "embedded Wasm" means that there are no chunks. |
changelog files have not been added for SNS yet, but that will happen very soon. If that goes in before this, then, yes, let's update those. Otherwise, this shouldn't be a blocker.
rs/sns/governance/proto/ic_sns_governance/pb/v1/governance.proto
Outdated
Show resolved
Hide resolved
rs/sns/governance/proto/ic_sns_governance/pb/v1/governance.proto
Outdated
Show resolved
Hide resolved
rs/nervous_system/integration_tests/tests/upgrade_sns_controlled_canister_with_large_wasm.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but with changes requested from our conversation.
This PR extends the existing proposal type
UpgradeSnsControllerCanister
with a new fieldchunked_canister_wasm
that can be used for specifying an upgrade to a large WASM module (over 2 MiB) priorly uploaded to some store canister.Example proposal render for chunked Wasm:
Example proposal render for embedded Wasm: