feat(nervous-system): Enable Root to upgrade canisters using chunked Wasms #3300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-dfinity
reviewed
Dec 30, 2024
max-dfinity
reviewed
Dec 30, 2024
max-dfinity
reviewed
Dec 30, 2024
|
This seems like a good first and necessary step. Can you add a test? |
Done (please see rs/nervous_system/integration_tests/tests/upgrade_sns_controlled_canister_with_large_wasm.rs) |
max-dfinity
reviewed
Dec 31, 2024
rs/nervous_system/integration_tests/tests/upgrade_sns_controlled_canister_with_large_wasm.rs
Show resolved
Hide resolved
max-dfinity
reviewed
Dec 31, 2024
rs/nervous_system/integration_tests/tests/upgrade_sns_controlled_canister_with_large_wasm.rs
Outdated
Show resolved
Hide resolved
rs/nervous_system/integration_tests/tests/upgrade_sns_controlled_canister_with_large_wasm.rs
Outdated
Show resolved
Hide resolved
dsarlis
approved these changes
Jan 6, 2025
aterga
force-pushed
the
arshavir/change-canister-with-chunked-wasm
branch
from
ae69b03 to
7432fe3
Compare
aterga
force-pushed
the
arshavir/change-canister-with-chunked-wasm
branch
from
7432fe3 to
d766949
Compare
NikolaMilosa
approved these changes
Jan 8, 2025
Co-authored-by: max-dfinity <100170574+max-dfinity@users.noreply.github.com>
aterga
force-pushed
the
arshavir/change-canister-with-chunked-wasm
branch
from
d766949 to
b183a0c
Compare
Bownairo
approved these changes
Jan 8, 2025
max-dfinity
reviewed
Jan 8, 2025
rs/nervous_system/integration_tests/tests/upgrade_sns_controlled_canister_with_large_wasm.rs
Show resolved
Hide resolved
max-dfinity
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables Root to upgrade canisters using chunked Wasms. This is relevant to both the NNS and the SNSs.