Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(recovery): [CON-1407] Add CLI option to use existing binaries for local recoveries #3301

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

dist1ll
Copy link
Contributor

@dist1ll dist1ll commented Dec 30, 2024

This PR adds ic-admin to the guest OS & adds a CLI argument to make the recovery tool use the local binaries from /opt/ic/bin.

With this, we can kick off a non-interactive, local subnet recovery via ssh, by calling the recovery tool with the right arguments. With this change, we should be able to create a system test for local recoveries.

To confirm that this works, I performed a non-interactive recovery on a testnet with the following arguments:

/opt/ic/bin/ic-recovery \
	--nns-url http://[2602:fb2b:110:10:5025:8bff:fe14:daee]:8080 \
	--test \
	--skip-prompts \
	--use-local-binaries \
	app-subnet-recovery \
	--subnet-id c3es6-ogziq-a5elm-47c4o-vkins-7kiu4-ekgun-oaeo2-ojd2m-j26wh-eae \
	--pub-key "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIFx8H9eVvkxl1n7crh/uUzqH03m8Qwlo2k5EE3MJa4Bs adrian.alic@dfinity.org" \
	--download-node 2602:fb2b:110:10:506a:22ff:fe1c:ef69 \
	--upload-method local \
	--keep-downloaded-state false

The subnet recovered successfully without user input.

@dist1ll dist1ll self-assigned this Dec 30, 2024
@github-actions github-actions bot added the feat label Dec 30, 2024
@dist1ll dist1ll changed the title feat(recovery): [CON-1407] Add recovery option to use local ic_admin feat(recovery): [CON-1407] Add recovery option to use existing binaries for local recoveries Dec 30, 2024
@dist1ll dist1ll changed the title feat(recovery): [CON-1407] Add recovery option to use existing binaries for local recoveries feat(recovery): [CON-1407] Add CLI option to use existing binaries for local recoveries Dec 30, 2024
@dist1ll dist1ll marked this pull request as ready for review December 30, 2024 09:03
@dist1ll dist1ll requested review from a team as code owners December 30, 2024 09:03
@eichhorl eichhorl added this pull request to the merge queue Jan 8, 2025
Merged via the queue into master with commit 41b1a2e Jan 8, 2025
28 checks passed
@eichhorl eichhorl deleted the alic/local-icadmin branch January 8, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants