chore(IDX): don't store bazel-targets #3851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This drops the `bazel-targets` which we previously used to keep a list of built targets. The list was used in `build-determinism` to check which targets were built by the `bazel-test-all` job, but since both `build-ic` and `bazel-test-all` use the same diffing logic (`diff.sh`) it's not necessary to pass the list around.
basvandijk
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the
bazel-targetswhich we previously used to keep a list of built targets. The list was used inbuild-determinismto check which targets were built by thebazel-test-alljob, but since bothbuild-icandbazel-test-alluse the same diffing logic (diff.sh) it's not necessary to pass the list around.Also includes a necessary fix that ensure that even if there are no targets,
build-ic.taris a valid tarball.