Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: CON-1422 vetKD payload builder/verifier unit tests #3886

Merged
merged 20 commits into from
Feb 18, 2025

Conversation

eichhorl
Copy link
Contributor

@eichhorl eichhorl commented Feb 10, 2025

This PR adds unit tests for the new vetKD payload builder. Some unit tests are still annotated with #[should_panic(expected = "not yet implemented")], as the current implementation doesn't call the correct crypto endpoints to create and validate combined vetKD shares yet. This will be added in a subsequent PR, at which point the annotation will be removed.

@github-actions github-actions bot added the test label Feb 10, 2025
@eichhorl eichhorl added the CI_COVERAGE Run bazel coverage and upload report to S3 label Feb 10, 2025
@eichhorl eichhorl added the CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 label Feb 11, 2025
@eichhorl eichhorl removed CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 CI_COVERAGE Run bazel coverage and upload report to S3 labels Feb 11, 2025
@eichhorl eichhorl changed the title test: vetkd payload builder/verifier test: CON-1422 vetKD payload builder/verifier unit tests Feb 11, 2025
@eichhorl eichhorl marked this pull request as ready for review February 11, 2025 12:25
@eichhorl eichhorl requested a review from a team as a code owner February 11, 2025 12:25
@eichhorl eichhorl requested a review from Sawchord February 11, 2025 12:25
Copy link
Contributor

@Sawchord Sawchord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Will complete review tomorrow

Copy link
Contributor

@Sawchord Sawchord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eichhorl eichhorl added this pull request to the merge queue Feb 18, 2025
Merged via the queue into master with commit edcb5ab Feb 18, 2025
24 checks passed
@eichhorl eichhorl deleted the eichhorl/vetkd-builder branch February 18, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants