fix: EXC-1889 Hook condition should be checked after every mgmt canister call #3988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragoljub-duric
commented
Feb 18, 2025
dragoljub-duric
commented
Feb 19, 2025
dragoljub-duric
commented
Feb 19, 2025
dragoljub-duric
commented
Feb 19, 2025
dragoljub-duric
commented
Feb 19, 2025
dragoljub-duric
commented
Feb 19, 2025
maksymar
reviewed
Feb 19, 2025
maksymar
approved these changes
Feb 19, 2025
dragoljub-duric
commented
Feb 19, 2025
ShuoWangNSL
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the condition for a low-wasm memory hook will be met after every mgmt canister call.
Since we already have tests that condition is checked after Updating settings and Installing code, we will only add tests that snapshot operations influence hook in the floow-up https://github.com/dfinity/ic/pull/4023/files.